Changeset 51436

Timestamp:

07/15/2021 09:06:20 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertTrue( is_a( ... ) ) with assertInstanceOf() to use native PHPUnit functionality.

Follow-up to [51335], [51337], [51367], [51397], [51403], [51404].

See #53363.

Location:

trunk/tests/phpunit/tests

Files:

• filesystem/base.php (modified) (1 diff)
• post/query.php (modified) (1 diff)
• sitemaps/functions.php (modified) (1 diff)
• taxonomy.php (modified) (1 diff)

trunk/tests/phpunit/tests/filesystem/base.php

@@ -30 +30 @@
         function test_is_MockFS_sane() {
                 global $wp_filesystem;
-                $this->assertTrue( is_a( $wp_filesystem, 'WP_Filesystem_MockFS' ) );
+                $this->assertInstanceOf( 'WP_Filesystem_MockFS', $wp_filesystem );
 
                 $wp_filesystem->init( '/' );

trunk/tests/phpunit/tests/post/query.php

@@ -103 +103 @@
 
                         // Posts are WP_Post objects.
-                        $this->assertTrue( is_a( $post, 'WP_Post' ) );
+                        $this->assertInstanceOf( 'WP_Post', $post );
 
                         // Filters are raw.

trunk/tests/phpunit/tests/sitemaps/functions.php

@@ -56 +56 @@
 
                 foreach ( $expected as $name => $provider ) {
-                        $this->assertTrue( is_a( $sitemaps[ $name ], $provider ), "Default $name sitemap is not a $provider object." );
+                        $this->assertInstanceOf( $provider, $sitemaps[ $name ], "Default $name sitemap is not a $provider object." );
                 }
         }

trunk/tests/phpunit/tests/taxonomy.php

@@ -439 +439 @@
                         'cat_name' => 'Error',
                 );
-                $this->assertTrue( is_a( wp_insert_category( $cat, true ), 'WP_Error' ) );
+                $this->assertInstanceOf( 'WP_Error', wp_insert_category( $cat, true ) );
         }