Changeset 51795

Timestamp:

09/10/2021 02:47:24 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Accessibility: Administration: Improve aria-label on network admin Themes screen.

This ensures that the beginning of the label matches the visible link text.

Add a similar label for the plugin URI link on the Plugins screen when the plugin is outside of the directory.

Follow-up to [28673], [28706], [35924].

Props sabernhardt, zeo, audrasjb.
Fixes #24442.

Location:

trunk/src/wp-admin/includes

Files:

• class-wp-ms-themes-list-table.php (modified) (1 diff)
• class-wp-plugins-list-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php

@@ -722 +722 @@
                 if ( $theme->get( 'ThemeURI' ) ) {
                         /* translators: %s: Theme name. */
-                        $aria_label = sprintf( __( 'Visit %s homepage' ), $theme->display( 'Name' ) );
+                        $aria_label = sprintf( __( 'Visit theme site for %s' ), $theme->display( 'Name' ) );
 
                         $theme_meta[] = sprintf(

trunk/src/wp-admin/includes/class-wp-plugins-list-table.php

@@ -1067 +1067 @@
                                                 );
                                         } elseif ( ! empty( $plugin_data['PluginURI'] ) ) {
+                                                /* translators: %s: Plugin name. */
+                                                $aria_label = sprintf( __( 'Visit plugin site for %s' ), $plugin_name );
+
                                                 $plugin_meta[] = sprintf(
-                                                        '<a href="%s">%s</a>',
+                                                        '<a href="%s" aria-label="%s">%s</a>',
                                                         esc_url( $plugin_data['PluginURI'] ),
+                                                        esc_attr( $aria_label ),
                                                         __( 'Visit plugin site' )
                                                 );