Changeset 52010 for trunk/tests/phpunit/tests/oembed/template.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/oembed/template.php (modified) (15 diffs)

trunk/tests/phpunit/tests/oembed/template.php

@@ -5 +5 @@
  */
 class Tests_Embed_Template extends WP_UnitTestCase {
-    function test_oembed_output_post() {
+    public function test_oembed_output_post() {
         $user = self::factory()->user->create_and_get(
             array(
@@ -37 +37 @@
     }
 
-    function test_oembed_output_post_with_thumbnail() {
+    public function test_oembed_output_post_with_thumbnail() {
         $post_id       = self::factory()->post->create(
             array(
@@ -70 +70 @@
     }
 
-    function test_oembed_output_404() {
+    public function test_oembed_output_404() {
         $this->go_to( home_url( '/?p=123&embed=true' ) );
         $GLOBALS['wp_query']->query_vars['embed'] = true;
@@ -85 +85 @@
     }
 
-    function test_oembed_output_attachment() {
+    public function test_oembed_output_attachment() {
         $post          = self::factory()->post->create_and_get();
         $file          = DIR_TESTDATA . '/images/canola.jpg';
@@ -114 +114 @@
     }
 
-    function test_oembed_output_draft_post() {
+    public function test_oembed_output_draft_post() {
         $post_id = self::factory()->post->create(
             array(
@@ -137 +137 @@
     }
 
-    function test_oembed_output_scheduled_post() {
+    public function test_oembed_output_scheduled_post() {
         $post_id = self::factory()->post->create(
             array(
@@ -161 +161 @@
     }
 
-    function test_oembed_output_private_post() {
+    public function test_oembed_output_private_post() {
         $post_id = self::factory()->post->create(
             array(
@@ -184 +184 @@
     }
 
-    function test_oembed_output_private_post_with_permissions() {
+    public function test_oembed_output_private_post_with_permissions() {
         $user_id = self::factory()->user->create( array( 'role' => 'editor' ) );
         wp_set_current_user( $user_id );
@@ -212 +212 @@
     }
 
-    function test_wp_embed_excerpt_more_no_embed() {
+    public function test_wp_embed_excerpt_more_no_embed() {
         $GLOBALS['wp_query'] = new WP_Query();
 
@@ -218 +218 @@
     }
 
-    function test_wp_embed_excerpt_more() {
+    public function test_wp_embed_excerpt_more() {
         $post_id = self::factory()->post->create(
             array(
@@ -240 +240 @@
     }
 
-    function test_is_embed_post() {
+    public function test_is_embed_post() {
         $this->assertFalse( is_embed() );
 
@@ -248 +248 @@
     }
 
-    function test_is_embed_attachment() {
+    public function test_is_embed_attachment() {
         $post_id       = self::factory()->post->create();
         $file          = DIR_TESTDATA . '/images/canola.jpg';
@@ -262 +262 @@
     }
 
-    function test_is_embed_404() {
+    public function test_is_embed_404() {
         $this->go_to( home_url( '/?p=12345&embed=true' ) );
         $this->assertTrue( is_embed() );
     }
 
-    function test_get_post_embed_html_non_existent_post() {
+    public function test_get_post_embed_html_non_existent_post() {
         $this->assertFalse( get_post_embed_html( 200, 200, 0 ) );
         $this->assertFalse( get_post_embed_html( 200, 200 ) );
     }
 
-    function test_get_post_embed_html() {
+    public function test_get_post_embed_html() {
         $post_id = self::factory()->post->create();
         $title   = esc_attr(
@@ -287 +287 @@
     }
 
-    function test_add_host_js() {
+    public function test_add_host_js() {
         wp_oembed_add_host_js();
 
@@ -300 +300 @@
      * @ticket 34698
      */
-    function test_js_no_ampersands() {
+    public function test_js_no_ampersands() {
         $this->assertStringNotContainsString( '&', file_get_contents( ABSPATH . WPINC . '/js/wp-embed.js' ) );
     }