Changeset 52351 for trunk/src/wp-includes/update.php

Timestamp:

12/10/2021 12:04:03 AM (3 years ago)

Author:

peterwilsoncc

Message:

Upgrade/install: Revert upgrader rollback features.

Revert the rollback features introduced for theme and plugin upgrades during the WordPress 5.9 cycle. A bug (suspected to be in third party virtualisation software) causes the upgrades to fail consistently on some set ups. The revert is to allow contributors further time to investigate mitigation options.

Reverts [52337], [52289], [52284], [51951], [52192], [51902], [51899], [51898], [51815].

Props pbiron, dlh, peterwilsoncc, galbaras, SergeyBiryukov, afragen, costdev, bronsonquick, aristath, noisysocks, desrosj, TobiasBg, hellofromTonya, francina, Boniu91.
See #54543, #54166, #51857.

File:

• trunk/src/wp-includes/update.php (modified) (2 diffs)

trunk/src/wp-includes/update.php

@@ -957 +957 @@
 }
 
-/**
- * Deletes all contents of the temp-backup directory.
- *
- * @since 5.9.0
- *
- * @global WP_Filesystem_Base $wp_filesystem WordPress filesystem subclass.
- */
-function wp_delete_all_temp_backups() {
-    /*
-     * Check if there's a lock, or if currently performing an Ajax request,
-     * in which case there's a chance we're doing an update.
-     * Reschedule for an hour from now and exit early.
-     */
-    if ( get_option( 'core_updater.lock' ) || get_option( 'auto_updater.lock' ) || wp_doing_ajax() ) {
-        wp_schedule_single_event( time() + HOUR_IN_SECONDS, 'wp_delete_temp_updater_backups' );
-        return;
-    }
-
-    add_action(
-        'shutdown',
-        /*
-         * This action runs on shutdown to make sure there's no plugin updates currently running.
-         * Using a closure in this case is OK since the action can be removed by removing the parent hook.
-         */
-        function() {
-            global $wp_filesystem;
-
-            if ( ! $wp_filesystem ) {
-                include_once ABSPATH . '/wp-admin/includes/file.php';
-                WP_Filesystem();
-            }
-
-            $dirlist = $wp_filesystem->dirlist( $wp_filesystem->wp_content_dir() . 'upgrade/temp-backup/' );
-
-            foreach ( array_keys( $dirlist ) as $dir ) {
-                if ( '.' === $dir || '..' === $dir ) {
-                    continue;
-                }
-
-                $wp_filesystem->delete( $wp_filesystem->wp_content_dir() . 'upgrade/temp-backup/' . $dir, true );
-            }
-        }
-    );
-}
-
 if ( ( ! is_main_site() && ! is_network_admin() ) || wp_doing_ajax() ) {
     return;
@@ -1026 +981 @@
 
 add_action( 'init', 'wp_schedule_update_checks' );
-
-add_action( 'wp_delete_temp_updater_backups', 'wp_delete_all_temp_backups' );