Changeset 52921 for trunk/src/wp-includes/taxonomy.php

Timestamp:

03/11/2022 11:05:02 AM (3 years ago)

Author:

spacedmonkey

Message:

Taxonomy: Use get_terms instead of a database lookup in term_exists().

Replace raw SQL queries to the terms table, with a call to the get_terms function. Using get_terms means that term_exists is now cached. For developers using term_exists where cache invalidation is disabled, such as importing, a workaround was added to ensure that queries are uncached.

Props Spacedmonkey, boonebgorges, flixos90, peterwilsoncc.
Fixes #36949.

File:

• trunk/src/wp-includes/taxonomy.php (modified) (4 diffs)

trunk/src/wp-includes/taxonomy.php

@@ -1520 +1520 @@
  *
  * @since 3.0.0
- *
- * @global wpdb $wpdb WordPress database abstraction object.
+ * @since 6.0.0 Converted to use `get_terms()`.
+ *
+ * @global bool $_wp_suspend_cache_invalidation
  *
  * @param int|string $term     The term to check. Accepts term ID, slug, or name.
@@ -1532 +1533 @@
  */
 function term_exists( $term, $taxonomy = '', $parent = null ) {
-    global $wpdb;
+    global $_wp_suspend_cache_invalidation;
 
     if ( null === $term ) {
@@ -1538 +1539 @@
     }
 
-    $select     = "SELECT term_id FROM $wpdb->terms as t WHERE ";
-    $tax_select = "SELECT tt.term_id, tt.term_taxonomy_id FROM $wpdb->terms AS t INNER JOIN $wpdb->term_taxonomy as tt ON tt.term_id = t.term_id WHERE ";
+    $defaults = array(
+        'get'                    => 'all',
+        'fields'                 => 'ids',
+        'number'                 => 1,
+        'update_term_meta_cache' => false,
+        'order'                  => 'ASC',
+        'orderby'                => 'term_id',
+        'suppress_filter'        => true,
+    );
+
+    // Ensure that while importing, queries are not cached.
+    if ( ! empty( $_wp_suspend_cache_invalidation ) ) {
+        // @todo Disable caching once #52710 is merged.
+        $defaults['cache_domain'] = microtime();
+    }
+
+    if ( ! empty( $taxonomy ) ) {
+        $defaults['taxonomy'] = $taxonomy;
+        $defaults['fields']   = 'all';
+    }
 
     if ( is_int( $term ) ) {
@@ -1545 +1564 @@
             return 0;
         }
-        $where = 't.term_id = %d';
-        if ( ! empty( $taxonomy ) ) {
-            // phpcs:ignore WordPress.DB.PreparedSQLPlaceholders.ReplacementsWrongNumber
-            return $wpdb->get_row( $wpdb->prepare( $tax_select . $where . ' AND tt.taxonomy = %s', $term, $taxonomy ), ARRAY_A );
-        } else {
-            return $wpdb->get_var( $wpdb->prepare( $select . $where, $term ) );
-        }
-    }
-
-    $term = trim( wp_unslash( $term ) );
-    $slug = sanitize_title( $term );
-
-    $where             = 't.slug = %s';
-    $else_where        = 't.name = %s';
-    $where_fields      = array( $slug );
-    $else_where_fields = array( $term );
-    $orderby           = 'ORDER BY t.term_id ASC';
-    $limit             = 'LIMIT 1';
+        $args  = wp_parse_args( array( 'include' => array( $term ) ), $defaults );
+        $terms = get_terms( $args );
+    } else {
+        $term = trim( wp_unslash( $term ) );
+        if ( '' === $term ) {
+            return null;
+        }
+
+        if ( ! empty( $taxonomy ) && is_numeric( $parent ) ) {
+            $defaults['parent'] = (int) $parent;
+        }
+
+        $args  = wp_parse_args( array( 'slug' => sanitize_title( $term ) ), $defaults );
+        $terms = get_terms( $args );
+        if ( empty( $terms ) || is_wp_error( $terms ) ) {
+            $args  = wp_parse_args( array( 'name' => $term ), $defaults );
+            $terms = get_terms( $args );
+        }
+    }
+
+    if ( empty( $terms ) || is_wp_error( $terms ) ) {
+        return null;
+    }
+
+    $_term = array_shift( $terms );
+
     if ( ! empty( $taxonomy ) ) {
-        if ( is_numeric( $parent ) ) {
-            $parent              = (int) $parent;
-            $where_fields[]      = $parent;
-            $else_where_fields[] = $parent;
-            $where              .= ' AND tt.parent = %d';
-            $else_where         .= ' AND tt.parent = %d';
-        }
-
-        $where_fields[]      = $taxonomy;
-        $else_where_fields[] = $taxonomy;
-
-        $result = $wpdb->get_row( $wpdb->prepare( "SELECT tt.term_id, tt.term_taxonomy_id FROM $wpdb->terms AS t INNER JOIN $wpdb->term_taxonomy as tt ON tt.term_id = t.term_id WHERE $where AND tt.taxonomy = %s $orderby $limit", $where_fields ), ARRAY_A );
-        if ( $result ) {
-            return $result;
-        }
-
-        return $wpdb->get_row( $wpdb->prepare( "SELECT tt.term_id, tt.term_taxonomy_id FROM $wpdb->terms AS t INNER JOIN $wpdb->term_taxonomy as tt ON tt.term_id = t.term_id WHERE $else_where AND tt.taxonomy = %s $orderby $limit", $else_where_fields ), ARRAY_A );
-    }
-
-    // phpcs:ignore WordPress.DB.PreparedSQLPlaceholders.UnfinishedPrepare
-    $result = $wpdb->get_var( $wpdb->prepare( "SELECT term_id FROM $wpdb->terms as t WHERE $where $orderby $limit", $where_fields ) );
-    if ( $result ) {
-        return $result;
-    }
-
-    // phpcs:ignore WordPress.DB.PreparedSQLPlaceholders.UnfinishedPrepare
-    return $wpdb->get_var( $wpdb->prepare( "SELECT term_id FROM $wpdb->terms as t WHERE $else_where $orderby $limit", $else_where_fields ) );
+        return array(
+            'term_id'          => (string) $_term->term_id,
+            'term_taxonomy_id' => (string) $_term->term_taxonomy_id,
+        );
+    }
+
+    return (string) $_term;
 }