Changeset 53029

Timestamp:

03/30/2022 10:43:08 AM (2 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Rename parameters that use reserved keywords in wp-admin/includes/class-wp-importer.php.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit renames the $string parameter to $text in WP_Importer::min_whitespace().

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #55327.

File:

• trunk/src/wp-admin/includes/class-wp-importer.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-importer.php

@@ -239 +239 @@
 
     /**
-     * Replace newlines, tabs, and multiple spaces with a single space
-     *
-     * @param string $string
+     * Replace newlines, tabs, and multiple spaces with a single space.
+     *
+     * @param string $text
      * @return string
      */
-    public function min_whitespace( $string ) {
-        return preg_replace( '|[\r\n\t ]+|', ' ', $string );
+    public function min_whitespace( $text ) {
+        return preg_replace( '|[\r\n\t ]+|', ' ', $text );
     }