Changeset 53151

Timestamp:

04/12/2022 06:05:45 AM (2 years ago)

Author:

peterwilsoncc

Message:

Options: Show error when updating all options exceeds max_input_vars.

On sites with a large number of options, the number of inputs when saving all options via the /wp-admin/options.php page may exceed PHP's max_input_vars setting, this will prevent saving.

An error is now shown if this is the case.

Props ishitaka, jorbin, maguijo, pento, sergeybiryukov.
Fixes #45438.

File:

• trunk/src/wp-admin/options.php (modified) (2 diffs)

trunk/src/wp-admin/options.php

@@ -256 +256 @@
             wp_die( __( 'Sorry, you are not allowed to modify unregistered settings for this site.' ) );
         }
-        $options = explode( ',', wp_unslash( $_POST['page_options'] ) );
+        $options = isset( $_POST['page_options'] ) ? explode( ',', wp_unslash( $_POST['page_options'] ) ) : null;
     } else {
         $options = $allowed_options[ $option_page ];
@@ -333 +333 @@
             load_default_textdomain( $user_language_new );
         }
+    } else {
+        add_settings_error( 'general', 'settings_updated', __( 'Settings save failed.' ), 'error' );
     }