Changeset 53360 for trunk/src/wp-includes/class.wp-scripts.php

Timestamp:

05/07/2022 02:51:54 AM (3 years ago)

Author:

peterwilsoncc

Message:

Script Loader: Fix i18n edge case breaking dependencies.

Prevent concatenation of scripts if the text domain is defined to ensure the dependency order is respected.

This accounts for an edge case in which replacing a core script via a plugin and a lack of translations (eg, for a US English site) could cause the JavaScript files to be ordered incorrectly.

Follow up to [52937].

Props audrasjb, boniu91, chaion07, costdev, hellofromtonya, jsnajdr, mukesh27, ndiego, ugyensupport.
Fixes #55628.

File:

• trunk/src/wp-includes/class.wp-scripts.php (modified) (2 diffs)

trunk/src/wp-includes/class.wp-scripts.php

@@ -311 +311 @@
             $inline_script_tag = '';
         }
+
+        $translations_stop_concat = ! empty( $obj->textdomain );
 
         $translations = $this->print_translations( $handle, false );
@@ -328 +330 @@
             $srce = apply_filters( 'script_loader_src', $src, $handle );
 
-            if ( $this->in_default_dir( $srce ) && ( $before_handle || $after_handle || $translations ) ) {
+            if ( $this->in_default_dir( $srce ) && ( $before_handle || $after_handle || $translations_stop_concat ) ) {
                 $this->do_concat = false;