Changeset 53395

Timestamp:

05/14/2022 03:08:58 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Query: Check if $wp_query is set in is_main_query().

This avoids a PHP fatal error and triggers a _doing_it_wrong() notice if is_main_query() is called too early, bringing consistency with all the other is_*() conditionals: is_single(), is_home(), etc.

Follow-up to [16947], [17068], [17083], [18699], [37985].

Props vdankbaar, nhadsall, johnbillion, costdev, thijsoo, teunvgisteren, timkersten655, SergeyBiryukov.
Fixes #55104.

Location:

trunk

Files:

• src/wp-includes/query.php (modified) (1 diff)
• tests/phpunit/tests/query/conditionals.php (modified) (1 diff)

trunk/src/wp-includes/query.php

@@ -901 +901 @@
 function is_main_query() {
         global $wp_query;
+
+        if ( ! isset( $wp_query ) ) {
+                _doing_it_wrong( __FUNCTION__, __( 'Conditional query tags do not work before the query is run. Before then, they always return false.' ), '6.1.0' );
+                return false;
+        }
 
         if ( 'pre_get_posts' === current_filter() ) {

trunk/tests/phpunit/tests/query/conditionals.php

@@ -1617 +1617 @@
         }
 
+        /**
+         * @ticket 55104
+         * @expectedIncorrectUsage is_main_query
+         */
+        public function test_is_main_query_returns_false_if_wp_query_is_not_set() {
+                unset( $GLOBALS['wp_query'] );
+
+                $this->assertFalse( is_main_query() );
+        }
+
 }