Changeset 53839

Timestamp:

08/05/2022 05:58:01 AM (2 years ago)

Author:

audrasjb

Message:

Coding standards: Properly escape URLs returned by self_admin_url() calls.

Props krishaweb, audrasjb, SergeyBiryukov.
Fixes #56329.

Location:

trunk/src/wp-admin

Files:

• includes/plugin-install.php (modified) (1 diff)
• includes/theme-install.php (modified) (1 diff)
• plugins.php (modified) (1 diff)
• update-core.php (modified) (1 diff)

trunk/src/wp-admin/includes/plugin-install.php

@@ -343 +343 @@
 <div class="upload-plugin">
     <p class="install-help"><?php _e( 'If you have a plugin in a .zip format, you may install or update it by uploading it here.' ); ?></p>
-    <form method="post" enctype="multipart/form-data" class="wp-upload-form" action="<?php echo self_admin_url( 'update.php?action=upload-plugin' ); ?>">
+    <form method="post" enctype="multipart/form-data" class="wp-upload-form" action="<?php echo esc_url( self_admin_url( 'update.php?action=upload-plugin' ) ); ?>">
         <?php wp_nonce_field( 'plugin-upload' ); ?>
         <label class="screen-reader-text" for="pluginzip"><?php _e( 'Plugin zip file' ); ?></label>

trunk/src/wp-admin/includes/theme-install.php

@@ -183 +183 @@
     ?>
 <p class="install-help"><?php _e( 'If you have a theme in a .zip format, you may install or update it by uploading it here.' ); ?></p>
-<form method="post" enctype="multipart/form-data" class="wp-upload-form" action="<?php echo self_admin_url( 'update.php?action=upload-theme' ); ?>">
+<form method="post" enctype="multipart/form-data" class="wp-upload-form" action="<?php echo esc_url( self_admin_url( 'update.php?action=upload-theme' ) ); ?>">
     <?php wp_nonce_field( 'theme-upload' ); ?>
     <label class="screen-reader-text" for="themezip"><?php _e( 'Theme zip file' ); ?></label>

trunk/src/wp-admin/plugins.php

@@ -727 +727 @@
 if ( ( ! is_multisite() || is_network_admin() ) && current_user_can( 'install_plugins' ) ) {
     ?>
-    <a href="<?php echo self_admin_url( 'plugin-install.php' ); ?>" class="page-title-action"><?php echo esc_html_x( 'Add New', 'plugin' ); ?></a>
+    <a href="<?php echo esc_url( self_admin_url( 'plugin-install.php' ) ); ?>" class="page-title-action"><?php echo esc_html_x( 'Add New', 'plugin' ); ?></a>
     <?php
 }

trunk/src/wp-admin/update-core.php

@@ -918 +918 @@
     </div>
     <script type="text/javascript">
-    window.location = '<?php echo self_admin_url( 'about.php?updated' ); ?>';
+    window.location = '<?php echo esc_url( self_admin_url( 'about.php?updated' ) ); ?>';
     </script>
     <?php