Changeset 53934 for trunk/src/wp-includes/post.php

Timestamp:

08/23/2022 07:57:17 PM (2 years ago)

Author:

antpb

Message:

Media: Account for Windows when normalizing file paths.
Previously, Windows paths in the path_is_absolute function resulted in incorrect URIs. This patch adjusts for forward slashes and adds tests for the get_attached_file function.
Props Whissi, SergeyBiryukov, desrosj, stevenlinx, birgire, davidbaumwald, costdev, peterwilsoncc, audrasjb, hellofromTonya, johnbillion.
Fixes #36308.

File:

• trunk/src/wp-includes/post.php (modified) (1 diff)

trunk/src/wp-includes/post.php

@@ -725 +725 @@
 
     // If the file is relative, prepend upload dir.
-    if ( $file && 0 !== strpos( $file, '/' ) && ! preg_match( '|^.:\\\|', $file ) ) {
+    if ( $file ) {
         $uploads = wp_get_upload_dir();
+
         if ( false === $uploads['error'] ) {
-            $file = $uploads['basedir'] . "/$file";
+            $file = path_join( $uploads['basedir'], $file );
         }
     }