Changeset 53972 for branches/5.1/src/wp-admin/plugins.php

Timestamp:

08/30/2022 03:40:19 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Grouped backports to the 5.1 branch.

• Posts, Post Types: Escape output within the_meta().
• General: Ensure bookmark query limits are numeric.
• Plugins: Escape output in error messages.
• Build/Test Tools: Allow the PHPCS plugin in Composer configuration.

Merges [52412,53958-53960] to the 5.1 branch.
Props tykoted, martinkrcho, xknown, dd32, peterwilsoncc, paulkevan, timothyblynjacobs.

Location:

branches/5.1

Files:

• . (modified) (1 prop)
• src/wp-admin/plugins.php (modified) (2 diffs)

branches/5.1/src/wp-admin/plugins.php

@@ -467 +467 @@
             __( 'The plugin %1$s has been <strong>deactivated</strong> due to an error: %2$s' ),
             '<code>' . esc_html( $plugin_file ) . '</code>',
-            $error->get_error_message()
+            esc_html( $error->get_error_message() )
         );
         echo '</p></div>';
@@ -518 +518 @@
     if ( is_wp_error( $delete_result ) ) :
         ?>
-        <div id="message" class="error notice is-dismissible"><p><?php printf( __( 'Plugin could not be deleted due to an error: %s' ), $delete_result->get_error_message() ); ?></p></div>
+        <div id="message" class="error notice is-dismissible"><p><?php printf( __( 'Plugin could not be deleted due to an error: %s' ), esc_html( $delete_result->get_error_message() ) ); ?></p></div>
         <?php else : ?>
         <div id="message" class="updated notice is-dismissible">