Changeset 54215 for trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php

Timestamp:

09/19/2022 09:06:08 PM (2 years ago)

Author:

davidbaumwald

Message:

Administration: Add new get_views_links method to WP_List_Table.

Many WP_List_Table child classes in core use mostly the same code to create their "view" links markup. To DRY-up the code, a new WP_List_Table->get_view_links method is being introduced to consolidate the HTML link generation when provided an array of links.

This change also implements this new method in the relevant WP_List_Table_xxx child classes get_views methods. Finally, unit tests are being added to validate view links markup and test for some "unhappy paths".

Props afercia, costdev, garrett-eclipse, Dharm1025, juhise, peterwilsoncc.
Fixes #42066.

File:

• trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php

@@ -445 +445 @@
 
             if ( 'search' !== $type ) {
-                $status_links[ $type ] = sprintf(
-                    "<a href='%s'%s>%s</a>",
-                    esc_url( add_query_arg( 'theme_status', $type, $url ) ),
-                    ( $type === $status ) ? ' class="current" aria-current="page"' : '',
-                    sprintf( $text, number_format_i18n( $count ) )
+                $status_links[ $type ] = array(
+                    'url'     => esc_url( add_query_arg( 'theme_status', $type, $url ) ),
+                    'label'   => sprintf( $text, number_format_i18n( $count ) ),
+                    'current' => $type === $status,
                 );
             }
         }
 
-        return $status_links;
+        return $this->get_views_links( $status_links );
     }