Changeset 55183 for trunk/src/wp-admin/upload.php

Timestamp:

02/01/2023 10:15:04 PM (23 months ago)

Author:

joedolson

Message:

Media: Ensure media IDs are type int in bulk editing.

Cast all array values to integers using array_map so functions like wp_delete_attachment receiving the expected variable type.

Props eherman24, joedolson.
Fixes #56170.

File:

• trunk/src/wp-admin/upload.php (modified) (4 diffs)

trunk/src/wp-admin/upload.php

@@ -220 +220 @@
         $post_ids = explode( ',', $_REQUEST['ids'] );
     }
+    $post_ids = array_map( 'intval', (array) $post_ids );
 
     $location = 'upload.php';
@@ -242 +243 @@
                 break;
             }
-            foreach ( (array) $post_ids as $post_id ) {
+            foreach ( $post_ids as $post_id ) {
                 if ( ! current_user_can( 'delete_post', $post_id ) ) {
                     wp_die( __( 'Sorry, you are not allowed to move this item to the Trash.' ) );
@@ -263 +264 @@
                 break;
             }
-            foreach ( (array) $post_ids as $post_id ) {
+            foreach ( $post_ids as $post_id ) {
                 if ( ! current_user_can( 'delete_post', $post_id ) ) {
                     wp_die( __( 'Sorry, you are not allowed to restore this item from the Trash.' ) );
@@ -278 +279 @@
                 break;
             }
-            foreach ( (array) $post_ids as $post_id_del ) {
+            foreach ( $post_ids as $post_id_del ) {
                 if ( ! current_user_can( 'delete_post', $post_id_del ) ) {
                     wp_die( __( 'Sorry, you are not allowed to delete this item.' ) );