Changeset 55273

Timestamp:

02/07/2023 04:42:11 PM (23 months ago)

Author:

davidbaumwald

Message:

Themes: Revert appearance tools theme support.

The appearance tools theme support(merged in [55067]) includes block gap, a feature that was not intended for themes without a theme.json.

Until it has been determined if the feature can and should be enabled in these themes, and has been successfully tested, the appearance tools theme support should be reverted.

Reverts [55067].

Props poena, Mamaduka, audrasjb.
Fixes #57649.

Location:

trunk

Files:

• src/wp-includes/class-wp-theme-json-resolver.php (modified) (1 diff)
• tests/phpunit/tests/theme/wpThemeJsonResolver.php (modified) (3 diffs)

trunk/src/wp-includes/class-wp-theme-json-resolver.php

@@ -315 +315 @@
             // Classic themes without a theme.json don't support global duotone.
             $theme_support_data['settings']['color']['defaultDuotone'] = false;
-
-            // Allow themes to enable appearance tools via theme_support.
-            if ( current_theme_supports( 'appearance-tools' ) ) {
-                $theme_support_data['settings']['appearanceTools'] = true;
-            }
         }
         $with_theme_supports = new WP_Theme_JSON( $theme_support_data );

trunk/tests/phpunit/tests/theme/wpThemeJsonResolver.php

@@ -434 +434 @@
     /**
      * @ticket 54336
-     * @ticket 56467
-     *
-     * @covers ::add_theme_support
      */
     public function test_add_theme_supports_are_loaded_for_themes_without_theme_json() {
@@ -459 +456 @@
         add_theme_support( 'editor-color-palette', $color_palette );
         add_theme_support( 'custom-line-height' );
-        add_theme_support( 'appearance-tools' );
 
         $settings = WP_Theme_JSON_Resolver::get_theme_data()->get_settings();
@@ -465 +461 @@
         remove_theme_support( 'custom-line-height' );
         remove_theme_support( 'editor-color-palette' );
-        remove_theme_support( 'appearance-tools' );
 
         $this->assertFalse( wp_theme_has_theme_json() );
         $this->assertTrue( $settings['typography']['lineHeight'] );
         $this->assertSame( $color_palette, $settings['color']['palette']['theme'] );
-        $this->assertTrue( $settings['border']['color'], 'Support for appearance-tools was not added.' );
     }