Make WordPress Core

Changeset 55273


Ignore:
Timestamp:
02/07/2023 04:42:11 PM (14 months ago)
Author:
davidbaumwald
Message:

Themes: Revert appearance tools theme support.

The appearance tools theme support(merged in [55067]) includes block gap, a feature that was not intended for themes without a theme.json.

Until it has been determined if the feature can and should be enabled in these themes, and has been successfully tested, the appearance tools theme support should be reverted.

Reverts [55067].

Props poena, Mamaduka, audrasjb.
Fixes #57649.

Location:
trunk
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/class-wp-theme-json-resolver.php

    r55231 r55273  
    315315            // Classic themes without a theme.json don't support global duotone.
    316316            $theme_support_data['settings']['color']['defaultDuotone'] = false;
    317 
    318             // Allow themes to enable appearance tools via theme_support.
    319             if ( current_theme_supports( 'appearance-tools' ) ) {
    320                 $theme_support_data['settings']['appearanceTools'] = true;
    321             }
    322317        }
    323318        $with_theme_supports = new WP_Theme_JSON( $theme_support_data );
  • trunk/tests/phpunit/tests/theme/wpThemeJsonResolver.php

    r55231 r55273  
    434434    /**
    435435     * @ticket 54336
    436      * @ticket 56467
    437      *
    438      * @covers ::add_theme_support
    439436     */
    440437    public function test_add_theme_supports_are_loaded_for_themes_without_theme_json() {
     
    459456        add_theme_support( 'editor-color-palette', $color_palette );
    460457        add_theme_support( 'custom-line-height' );
    461         add_theme_support( 'appearance-tools' );
    462458
    463459        $settings = WP_Theme_JSON_Resolver::get_theme_data()->get_settings();
     
    465461        remove_theme_support( 'custom-line-height' );
    466462        remove_theme_support( 'editor-color-palette' );
    467         remove_theme_support( 'appearance-tools' );
    468463
    469464        $this->assertFalse( wp_theme_has_theme_json() );
    470465        $this->assertTrue( $settings['typography']['lineHeight'] );
    471466        $this->assertSame( $color_palette, $settings['color']['palette']['theme'] );
    472         $this->assertTrue( $settings['border']['color'], 'Support for appearance-tools was not added.' );
    473467    }
    474468
Note: See TracChangeset for help on using the changeset viewer.