Changeset 55652

Timestamp:

04/15/2023 12:09:08 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison where strlen() is involved.

Follow-up to [649], [1345], [3034], [6132], [6314], [6974], [55642].

Props aristath, poena, afercia, SergeyBiryukov.
See #57839.

Location:

trunk/src/wp-includes

Files:

• formatting.php (modified) (2 diffs)
• kses.php (modified) (1 diff)
• load.php (modified) (2 diffs)
• post-template.php (modified) (2 diffs)

trunk/src/wp-includes/formatting.php

@@ -899 +899 @@
                 }
                 for ( $j = 0; $j < $n; $j++ ) { // n bytes matching 10bbbbbb follow ?
-                        if ( ( ++$i == $length ) || ( ( ord( $str[ $i ] ) & 0xC0 ) != 0x80 ) ) {
+                        if ( ( ++$i === $length ) || ( ( ord( $str[ $i ] ) & 0xC0 ) != 0x80 ) ) {
                                 return false;
                         }
@@ -5139 +5139 @@
         while ( $len > $start ) {
                 // Last character: append and break.
-                if ( strlen( $pattern ) - 1 == $start ) {
+                if ( strlen( $pattern ) - 1 === $start ) {
                         $result .= substr( $pattern, -1 );
                         break;

trunk/src/wp-includes/kses.php

@@ -1331 +1331 @@
         // Loop through the whole attribute list.
 
-        while ( strlen( $attr ) != 0 ) {
+        while ( strlen( $attr ) !== 0 ) {
                 $working = 0; // Was the last operation successful?
 

trunk/src/wp-includes/load.php

@@ -41 +41 @@
 
         // Fix for IIS when running with PHP ISAPI.
-        if ( empty( $_SERVER['REQUEST_URI'] ) || ( 'cgi-fcgi' !== PHP_SAPI && preg_match( '/^Microsoft-IIS\//', $_SERVER['SERVER_SOFTWARE'] ) ) ) {
+        if ( empty( $_SERVER['REQUEST_URI'] )
+                || ( 'cgi-fcgi' !== PHP_SAPI && preg_match( '/^Microsoft-IIS\//', $_SERVER['SERVER_SOFTWARE'] ) )
+        ) {
 
                 if ( isset( $_SERVER['HTTP_X_ORIGINAL_URL'] ) ) {
@@ -72 +74 @@
 
         // Fix for PHP as CGI hosts that set SCRIPT_FILENAME to something ending in php.cgi for all requests.
-        if ( isset( $_SERVER['SCRIPT_FILENAME'] ) && ( strpos( $_SERVER['SCRIPT_FILENAME'], 'php.cgi' ) == strlen( $_SERVER['SCRIPT_FILENAME'] ) - 7 ) ) {
+        if ( isset( $_SERVER['SCRIPT_FILENAME'] )
+                && ( strpos( $_SERVER['SCRIPT_FILENAME'], 'php.cgi' ) === strlen( $_SERVER['SCRIPT_FILENAME'] ) - 7 )
+        ) {
                 $_SERVER['SCRIPT_FILENAME'] = $_SERVER['PATH_TRANSLATED'];
         }

trunk/src/wp-includes/post-template.php

@@ -43 +43 @@
         $title = get_the_title();
 
-        if ( strlen( $title ) == 0 ) {
+        if ( strlen( $title ) === 0 ) {
                 return;
         }
@@ -89 +89 @@
         $title = get_the_title( $parsed_args['post'] );
 
-        if ( strlen( $title ) == 0 ) {
+        if ( strlen( $title ) === 0 ) {
                 return;
         }