Changeset 56009

Timestamp:

06/24/2023 03:58:37 AM (18 months ago)

Author:

audrasjb

Message:

Upgrade/Install: Prevent users from sending multiple bulk plugin updates.

This changeset improves update.js by adding is-enqueued class to enqueued plugin updates to prevent users from asking for several updates for the same
plugin at the same time, which previously resulted to …an interesting experience.

Props bitnissen, swissspidy, MarcGuay, xkon, afercia, swissspidy, bookdude13, simonemanfre, vasilism, costdev, zunaid321.
Fixes #40966.

File:

• trunk/src/js/_enqueues/wp/updates.js (modified) (3 diffs)

trunk/src/js/_enqueues/wp/updates.js

@@ -516 +516 @@
         if ( 'plugins' === pagenow || 'plugins-network' === pagenow ) {
             $pluginRow     = $( 'tr[data-plugin="' + response.plugin + '"]' )
-                .removeClass( 'update' )
+                .removeClass( 'update is-enqueued' )
                 .addClass( 'updated' );
             $updateMessage = $pluginRow.find( '.update-message' )
@@ -586 +586 @@
 
         if ( 'plugins' === pagenow || 'plugins-network' === pagenow ) {
+            $pluginRow = $( 'tr[data-plugin="' + response.plugin + '"]' ).removeClass( 'is-enqueued' );
+
             if ( response.plugin ) {
                 $message = $( 'tr[data-plugin="' + response.plugin + '"]' ).find( '.update-message' );
@@ -2469 +2471 @@
                 }
 
+                // Don't add items to the update queue again, even if the user clicks the update button several times.
+                if ( 'update-selected' === bulkAction && $itemRow.hasClass( 'is-enqueued' ) ) {
+                    return;
+                }
+
+                $itemRow.addClass( 'is-enqueued' )
+
                 // Add it to the queue.
                 wp.updates.queue.push( {