Changeset 56031 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php

Timestamp:

06/26/2023 10:15:04 AM (22 months ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Use str_contains() in a few more places.

str_contains() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) contains the given substring (needle).

WordPress core includes a polyfill for str_contains() on PHP < 8.0 as of WordPress 5.9.

This commit replaces false !== strpos( ... ) with str_contains() in core files, making the code more readable and consistent, as well as better aligned with modern development practices.

Follow-up to [55988], [56021].

See #58206.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php (modified) (2 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php

@@ -1112 +1112 @@
             $value = trim( $value );
 
-            if ( strpos( $value, ';' ) === false ) {
+            if ( ! str_contains( $value, ';' ) ) {
                 continue;
             }
@@ -1122 +1122 @@
 
             foreach ( $attr_parts as $part ) {
-                if ( strpos( $part, '=' ) === false ) {
+                if ( ! str_contains( $part, '=' ) ) {
                     continue;
                 }