WordPress.org
Get WordPress

Make WordPress Core

Changeset 56450


Ignore:
Timestamp:
08/24/2023 04:12:01 PM (16 months ago)
Author:
joedolson
Message:

Menus: Revert unintentional changes in [56449].

Accidentally committed two simultaneous patches; reverting unintended list table changes.

Unprops joedolson.
See #56594.

Location:
trunk/src/wp-admin
Files:
14 edited

Legend:

Unmodified
Added
Removed

  • trunk/src/wp-admin/css/list-tables.css

    r56449 r56450  
    571571}
    572572
    573 .check-column label {
     573.check-column .label-covers-full-cell {
    574574    width: 100%;
    575575    height: 100%;
    … …  
    580580}
    581581
    582 .check-column input {
     582.check-column .label-covers-full-cell + input {
    583583    position: relative;
    584584    z-index: 1;
    585585}
    586586
    587 .check-column:hover input {
     587.check-column .label-covers-full-cell:hover + input {
    588588    box-shadow: 0 0 0 1px #2271b1;
    589589}

  • trunk/src/wp-admin/includes/class-wp-comments-list-table.php

    r56449 r56450  
    896896        if ( $this->user_can ) {
    897897            ?>
    898         <input id="cb-select-<?php echo $comment->comment_ID; ?>" type="checkbox" name="delete_comments[]" value="<?php echo $comment->comment_ID; ?>" />
    899         <label for="cb-select-<?php echo $comment->comment_ID; ?>">
     898        <label class="label-covers-full-cell" for="cb-select-<?php echo $comment->comment_ID; ?>">
    900899            <span class="screen-reader-text">
    901900            <?php
    … …  
    905904            </span>
    906905        </label>
     906        <input id="cb-select-<?php echo $comment->comment_ID; ?>" type="checkbox" name="delete_comments[]" value="<?php echo $comment->comment_ID; ?>" />
    907907            <?php
    908908        }

  • trunk/src/wp-admin/includes/class-wp-links-list-table.php

    r56449 r56450  
    175175
    176176        ?>
    177         <input type="checkbox" name="linkcheck[]" id="cb-select-<?php echo $link->link_id; ?>" value="<?php echo esc_attr( $link->link_id ); ?>" />
    178         <label for="cb-select-<?php echo $link->link_id; ?>">
     177        <label class="label-covers-full-cell" for="cb-select-<?php echo $link->link_id; ?>">
    179178            <span class="screen-reader-text">
    180179            <?php
    … …  
    184183            </span>
    185184        </label>
     185        <input type="checkbox" name="linkcheck[]" id="cb-select-<?php echo $link->link_id; ?>" value="<?php echo esc_attr( $link->link_id ); ?>" />
    186186        <?php
    187187    }

  • trunk/src/wp-admin/includes/class-wp-list-table.php

    r56449 r56450  
    14001400        if ( ! empty( $columns['cb'] ) ) {
    14011401            static $cb_counter = 1;
    1402             $columns['cb']     = '<input id="cb-select-all-' . $cb_counter . '" type="checkbox" />
    1403             <label for="cb-select-all-' . $cb_counter . '">' .
     1402            $columns['cb']     = '<label class="label-covers-full-cell" for="cb-select-all-' . $cb_counter . '">' .
    14041403                '<span class="screen-reader-text">' .
    14051404                    /* translators: Hidden accessibility text. */
    14061405                    __( 'Select All' ) .
    14071406                '</span>' .
    1408                 '</label>';
     1407                '</label>' .
     1408                '<input id="cb-select-all-' . $cb_counter . '" type="checkbox" />';
    14091409            $cb_counter++;
    14101410        }

  • trunk/src/wp-admin/includes/class-wp-media-list-table.php

    r56449 r56450  
    420420        if ( current_user_can( 'edit_post', $post->ID ) ) {
    421421            ?>
    422             <input type="checkbox" name="media[]" id="cb-select-<?php echo $post->ID; ?>" value="<?php echo $post->ID; ?>" />
    423             <label for="cb-select-<?php echo $post->ID; ?>">
     422            <label class="label-covers-full-cell" for="cb-select-<?php echo $post->ID; ?>">
    424423                <span class="screen-reader-text">
    425424                <?php
    … …  
    429428                </span>
    430429            </label>
     430            <input type="checkbox" name="media[]" id="cb-select-<?php echo $post->ID; ?>" value="<?php echo $post->ID; ?>" />
    431431            <?php
    432432        }

  • trunk/src/wp-admin/includes/class-wp-ms-sites-list-table.php

    r56449 r56450  
    421421            $blogname = untrailingslashit( $blog['domain'] . $blog['path'] );
    422422            ?>
    423             <input type="checkbox" id="blog_<?php echo $blog['blog_id']; ?>" name="allblogs[]"
    424                 value="<?php echo esc_attr( $blog['blog_id'] ); ?>" />
    425             <label for="blog_<?php echo $blog['blog_id']; ?>">
     423            <label class="label-covers-full-cell" for="blog_<?php echo $blog['blog_id']; ?>">
    426424                <span class="screen-reader-text">
    427425                <?php
    … …  
    431429                </span>
    432430            </label>
     431            <input type="checkbox" id="blog_<?php echo $blog['blog_id']; ?>" name="allblogs[]"
     432                value="<?php echo esc_attr( $blog['blog_id'] ); ?>" />
    433433            <?php
    434434        endif;

  • trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php

    r56449 r56450  
    513513        $checkbox_id = 'checkbox_' . md5( $theme->get( 'Name' ) );
    514514        ?>
    515         <input type="checkbox" name="checked[]" value="<?php echo esc_attr( $theme->get_stylesheet() ); ?>" id="<?php echo $checkbox_id; ?>" />
    516         <label for="<?php echo $checkbox_id; ?>" >
     515        <label class="label-covers-full-cell" for="<?php echo $checkbox_id; ?>" >
    517516            <span class="screen-reader-text">
    518517            <?php
    … …  
    525524            </span>
    526525        </label>
     526        <input type="checkbox" name="checked[]" value="<?php echo esc_attr( $theme->get_stylesheet() ); ?>" id="<?php echo $checkbox_id; ?>" />
    527527        <?php
    528528    }

  • trunk/src/wp-admin/includes/class-wp-ms-users-list-table.php

    r56449 r56450  
    236236        }
    237237        ?>
    238         <input type="checkbox" id="blog_<?php echo $user->ID; ?>" name="allusers[]" value="<?php echo esc_attr( $user->ID ); ?>" />
    239         <label for="blog_<?php echo $user->ID; ?>">
     238        <label class="label-covers-full-cell" for="blog_<?php echo $user->ID; ?>">
    240239            <span class="screen-reader-text">
    241240            <?php
    … …  
    245244            </span>
    246245        </label>
     246        <input type="checkbox" id="blog_<?php echo $user->ID; ?>" name="allusers[]" value="<?php echo esc_attr( $user->ID ); ?>" />
    247247        <?php
    248248    }

  • trunk/src/wp-admin/includes/class-wp-plugins-list-table.php

    r56449 r56450  
    994994        } else {
    995995            $checkbox = sprintf(
    996                 '<input type="checkbox" name="checked[]" value="%3$s" id="%1$s" />' .
    997                 '<label for="%1$s"><span class="screen-reader-text">%2$s</span></label>',
     996                '<label class="label-covers-full-cell" for="%1$s"><span class="screen-reader-text">%2$s</span></label>' .
     997                '<input type="checkbox" name="checked[]" value="%3$s" id="%1$s" />',
    998998                $checkbox_id,
    999999                /* translators: Hidden accessibility text. %s: Plugin name. */

  • trunk/src/wp-admin/includes/class-wp-posts-list-table.php

    r56449 r56450  
    10341034        if ( apply_filters( 'wp_list_table_show_post_checkbox', $show, $post ) ) :
    10351035            ?>
    1036             <input id="cb-select-<?php the_ID(); ?>" type="checkbox" name="post[]" value="<?php the_ID(); ?>" />
    1037             <label for="cb-select-<?php the_ID(); ?>">
     1036            <label class="label-covers-full-cell" for="cb-select-<?php the_ID(); ?>">
    10381037                <span class="screen-reader-text">
    10391038                <?php
    … …  
    10431042                </span>
    10441043            </label>
     1044            <input id="cb-select-<?php the_ID(); ?>" type="checkbox" name="post[]" value="<?php the_ID(); ?>" />
    10451045            <div class="locked-indicator">
    10461046                <span class="locked-indicator-icon" aria-hidden="true"></span>

  • trunk/src/wp-admin/includes/class-wp-privacy-requests-table.php

    r56449 r56450  
    417417    public function column_cb( $item ) {
    418418        return sprintf(
    419             '<input type="checkbox" name="request_id[]" id="requester_%1$s" value="%1$s" /><span class="spinner"></span>' .
    420             '<label for="requester_%1$s"><span class="screen-reader-text">%2$s</span></label>',
     419            '<label class="label-covers-full-cell" for="requester_%1$s"><span class="screen-reader-text">%2$s</span></label>' .
     420            '<input type="checkbox" name="request_id[]" id="requester_%1$s" value="%1$s" /><span class="spinner"></span>',
    421421            esc_attr( $item->ID ),
    422422            /* translators: Hidden accessibility text. %s: Email address. */

  • trunk/src/wp-admin/includes/class-wp-terms-list-table.php

    r56449 r56450  
    366366        if ( current_user_can( 'delete_term', $tag->term_id ) ) {
    367367            return sprintf(
    368                 '<input type="checkbox" name="delete_tags[]" value="%1$s" id="cb-select-%1$s" />' .
    369                 '<label for="cb-select-%1$s"><span class="screen-reader-text">%2$s</span></label>',
     368                '<label class="label-covers-full-cell" for="cb-select-%1$s"><span class="screen-reader-text">%2$s</span></label>' .
     369                '<input type="checkbox" name="delete_tags[]" value="%1$s" id="cb-select-%1$s" />',
    370370                $tag->term_id,
    371371                /* translators: Hidden accessibility text. %s: Taxonomy term name. */

  • trunk/src/wp-admin/includes/class-wp-users-list-table.php

    r56449 r56450  
    525525            // Set up the checkbox (because the user is editable, otherwise it's empty).
    526526            $checkbox = sprintf(
    527                 '<input type="checkbox" name="users[]" id="user_%1$s" class="%3$s" value="%1$s" />' .
    528                 '<label for="user_%1$s"><span class="screen-reader-text">%2$s</span></label>',
     527                '<label class="label-covers-full-cell" for="user_%1$s"><span class="screen-reader-text">%2$s</span></label>' .
     528                '<input type="checkbox" name="users[]" id="user_%1$s" class="%3$s" value="%1$s" />',
    529529                $user_object->ID,
    530530                /* translators: Hidden accessibility text. %s: User login. */

  • trunk/src/wp-admin/update-core.php

    r56449 r56450  
    572572        <td class="check-column">
    573573            <?php if ( $compatible_php ) : ?>
    574                 <label for="<?php echo $checkbox_id; ?>">
     574                <label for="<?php echo $checkbox_id; ?>" class="label-covers-full-cell">
    575575                    <span class="screen-reader-text">
    576576                    <?php
    … …  
    750750        <td class="check-column">
    751751            <?php if ( $compatible_wp && $compatible_php ) : ?>
    752                 <label for="<?php echo $checkbox_id; ?>">
     752                <label for="<?php echo $checkbox_id; ?>" class="label-covers-full-cell">
    753753                    <span class="screen-reader-text">
    754754                    <?php
Note: See TracChangeset for help on using the changeset viewer.