Changeset 56616

Timestamp:

09/19/2023 12:23:16 PM (8 months ago)

Author:

costdev

Message:

Coding Standards: Replace PHP alias join() with implode().

In [52190], some new instances of the join() alias were introduced in the test suite.

Using the canonical function name for PHP functions is strongly recommended, as aliases may be deprecated or removed without (much) warning.

This replaces the new join() uses with the canonical implode() function name.

Follow-up to [46182], [49193], [49805], [52190].

Props david.binda, mukesh27.
Fixes #59389.

Location:

trunk/tests/phpunit/tests

Files:

• media.php (modified) (6 diffs)
• media/getPostGalleries.php (modified) (3 diffs)

trunk/tests/phpunit/tests/media.php

@@ -553 +553 @@
         }
 
-        $ids1_joined = join( ',', array_slice( $ids1, 0, 3 ) );
-        $ids2_joined = join( ',', array_slice( $ids2, 3, 3 ) );
+        $ids1_joined = implode( ',', array_slice( $ids1, 0, 3 ) );
+        $ids2_joined = implode( ',', array_slice( $ids2, 3, 3 ) );
 
         $blob    = <<<BLOB
@@ -639 +639 @@
         }
 
-        $imgs1_joined = join( "\n", array_slice( $imgs, 0, 3 ) );
-        $imgs2_joined = join( "\n", array_slice( $imgs, 3, 3 ) );
+        $imgs1_joined = implode( "\n", array_slice( $imgs, 0, 3 ) );
+        $imgs2_joined = implode( "\n", array_slice( $imgs, 3, 3 ) );
 
         $blob    = <<<BLOB
@@ -678 +678 @@
         }
 
-        $ids1_joined = join( ',', array_slice( $ids, 0, 3 ) );
-        $ids2_joined = join( ',', array_slice( $ids, 3, 3 ) );
+        $ids1_joined = implode( ',', array_slice( $ids, 0, 3 ) );
+        $ids2_joined = implode( ',', array_slice( $ids, 3, 3 ) );
 
         $blob    = <<<BLOB
@@ -719 +719 @@
         }
 
-        $ids1_joined  = join( "\n", array_slice( $ids, 0, 3 ) );
-        $ids2_joined  = join( "\n", array_slice( $ids, 3, 3 ) );
-        $imgs2_joined = join( "\n", array_slice( $imgs, 3, 3 ) );
+        $ids1_joined  = implode( "\n", array_slice( $ids, 0, 3 ) );
+        $ids2_joined  = implode( "\n", array_slice( $ids, 3, 3 ) );
+        $imgs2_joined = implode( "\n", array_slice( $imgs, 3, 3 ) );
 
         $blob    = <<<BLOB
@@ -763 +763 @@
         }
 
-        $imgs_joined = join( "\n", $imgs );
+        $imgs_joined = implode( "\n", $imgs );
 
         $blob    = <<<BLOB
@@ -806 +806 @@
         }
 
-        $imgs_joined = join( "\n", $imgs );
+        $imgs_joined = implode( "\n", $imgs );
 
         $blob    = <<<BLOB

trunk/tests/phpunit/tests/media/getPostGalleries.php

@@ -576 +576 @@
         }
 
-        $ids_joined = join( ',', $ids );
+        $ids_joined = implode( ',', $ids );
 
         $global_post_id = self::factory()->post->create(
@@ -845 +845 @@
         }
 
-        $ids1_joined = join( ',', array_slice( $ids, 0, 3 ) );
-        $ids2_joined = join( ',', array_slice( $ids, 3, 3 ) );
+        $ids1_joined = implode( ',', array_slice( $ids, 0, 3 ) );
+        $ids2_joined = implode( ',', array_slice( $ids, 3, 3 ) );
 
         $blob = <<<BLOB
@@ -908 +908 @@
         }
 
-        $ids1_joined = join( ',', array_slice( $ids, 0, 3 ) );
-        $ids2_joined = join( ',', array_slice( $ids, 3, 3 ) );
+        $ids1_joined = implode( ',', array_slice( $ids, 0, 3 ) );
+        $ids2_joined = implode( ',', array_slice( $ids, 3, 3 ) );
         $blob        = <<<BLOB
 [gallery ids="$ids1_joined" type="type" foo="bar"]