Changeset 56953

Timestamp:

10/17/2023 10:37:35 AM (15 months ago)

Author:

SergeyBiryukov

Message:

HTML API: Scan to end of tag when getting updated HTML output.

When applying updates to HTML, one step was left out in [56941] which updated the position of the end of the current tag. This made it possible to create bookmarks with null or earlier end positions than their start position. This in turn broke the Directive Processor in Gutenberg during the backport of changes from Core into Gutenberg.

In this commit, after applying updates, the HTML document is now scanned fully to the end of the current tag, updating the internal pointer to its end, so that nothing else will be broken or misaligned.

Follow-up to [56941].

Props dmsnell.
Fixes #59643.

File:

• trunk/src/wp-includes/html-api/class-wp-html-tag-processor.php (modified) (1 diff)

trunk/src/wp-includes/html-api/class-wp-html-tag-processor.php

@@ -2325 +2325 @@
         }
 
+        $tag_ends_at                = strpos( $this->html, '>', $this->bytes_already_parsed );
+        $this->tag_ends_at          = $tag_ends_at;
+        $this->bytes_already_parsed = $tag_ends_at;
+
         return $this->html;
     }