Changeset 57641 for trunk/src/wp-includes/block-bindings/post-meta.php

Timestamp:

02/16/2024 12:53:16 PM (13 months ago)

Author:

gziolo

Message:

Editor: Merge uses_context defined by block bindings sources with block types

Adds logic that fixes the limitation for souces by allowing merging the uses_context defined by block bindings sources into supported block types. Each source defines the context it needs and it is added to the block types that are using the block bindings API.

Fixes #60525.
Props santosguillamot, gziolo, czapla, thekt12.

File:

• trunk/src/wp-includes/block-bindings/post-meta.php (modified) (2 diffs)

trunk/src/wp-includes/block-bindings/post-meta.php

@@ -14 +14 @@
  * @access private
  *
- * @param array $source_args Array containing source arguments used to look up the override value.
- *                           Example: array( "key" => "foo" ).
+ * @param array    $source_args    Array containing source arguments used to look up the override value.
+ *                                 Example: array( "key" => "foo" ).
+ * @param WP_Block $block_instance The block instance.
  * @return mixed The value computed for the source.
  */
-function _block_bindings_post_meta_get_value( array $source_args ) {
-    if ( ! isset( $source_args['key'] ) ) {
+function _block_bindings_post_meta_get_value( array $source_args, $block_instance ) {
+    if ( empty( $source_args['key'] ) ) {
         return null;
     }
 
-    // Use the postId attribute if available.
-    if ( isset( $source_args['postId'] ) ) {
-        $post_id = $source_args['postId'];
-    } else {
-        // $block_instance->context['postId'] is not available in the Image block.
-        $post_id = get_the_ID();
+    if ( empty( $block_instance->context['postId'] ) ) {
+        return null;
     }
+    $post_id = $block_instance->context['postId'];
 
     // If a post isn't public, we need to prevent unauthorized users from accessing the post meta.
@@ -52 +50 @@
             'label'              => _x( 'Post Meta', 'block bindings source' ),
             'get_value_callback' => '_block_bindings_post_meta_get_value',
+            'uses_context'       => array( 'postId', 'postType' ),
         )
     );