Changeset 58863 for branches/6.6/src/wp-includes/class-wp-walker.php

Timestamp:

08/07/2024 07:45:55 PM (11 months ago)

Author:

hellofromTonya

Message:

General: Cast $max_depth and $depth to an integer in the Walker class.

This ensures that the arguments are correctly interpreted when passed as a query string, i.e. when wp_parse_args() is involved. For example, wp_list_pages( 'depth=0' ) should display a list of all pages to the maximum depth.

Follow-up to [57848].

Reviewed by peterwilsoncc.
Merges [58812] to the 6.6 branch.

Props freibergergarcia, peterwilsoncc, ahortin.
Fixes #61749.

Location:

branches/6.6

Files:

• . (modified) (1 prop)
• src/wp-includes/class-wp-walker.php (modified) (3 diffs)

branches/6.6/src/wp-includes/class-wp-walker.php

@@ -136 +136 @@
         }
 
+        $max_depth = (int) $max_depth;
+        $depth     = (int) $depth;
+
         $id_field = $this->db_fields['id'];
         $id       = $element->$id_field;
@@ -191 +194 @@
     public function walk( $elements, $max_depth, ...$args ) {
         $output = '';
+
+        $max_depth = (int) $max_depth;
 
         // Invalid parameter or nothing to walk.
@@ -286 +291 @@
      */
     public function paged_walk( $elements, $max_depth, $page_num, $per_page, ...$args ) {
+        $output = '';
+
+        $max_depth = (int) $max_depth;
+
         if ( empty( $elements ) || $max_depth < -1 ) {
-            return '';
-        }
-
-        $output = '';
+            return $output;
+        }
 
         $parent_field = $this->db_fields['parent'];