Changeset 5908 for trunk/wp-admin/includes/upgrade.php

Timestamp:

08/21/2007 12:11:46 AM (19 years ago)

Author:

ryan

Message:

Really make slugs unique during upgrade. fixes #4776

File:

• trunk/wp-admin/includes/upgrade.php (modified) (1 diff)

trunk/wp-admin/includes/upgrade.php

@@ -539 +539 @@
                 // Associate terms with the same slug in a term group and make slugs unique.
                 if ( $exists = $wpdb->get_results("SELECT term_id, term_group FROM $wpdb->terms WHERE slug = '$slug'") ) {
-                        $num = count($exists);
-                        $num++;
-                        $slug = $slug . "-$num";
                         $term_group = $exists[0]->term_group;
                         $id = $exists[0]->term_id;
+                        $num = 2;
+                        do {
+                                $alt_slug = $slug . "-$num";
+                                $num++;
+                                $slug_check = $wpdb->get_var("SELECT slug FROM $wpdb->terms WHERE slug = '$alt_slug'");
+                        } while ( $slug_check );
+
+                        $slug = $alt_slug;
+
                         if ( empty( $term_group ) ) {
                                 $term_group = $wpdb->get_var("SELECT MAX(term_group) FROM $wpdb->terms GROUP BY term_group") + 1;