Changeset 59091 for trunk/src/wp-includes/class-wp.php

Timestamp:

09/25/2024 07:35:20 PM (3 months ago)

Author:

hellofromTonya

Message:

Canonical: Redirect when front page's paginated states not found.

Perform a canonical redirect for an invalid pagination request of a static front page.

When a site has a static front page assigned and that page has a <!--nextpage--> within its content, previously accessing non-existing pages (e.g. example.com/page/3/) did not redirect or return a 404 or 301. This changeset resolves that issue by performing a canonical redirect.

Unit tests are also included for this specific use case and to ensure the fix does not affect a blog listing home page.

Follow-up to [47738], [47727], [34492].

Props dd32, audrasjb, chaion07, hellofromTonya, joemcgill, lukecarbis, Mte90, mukesh27, peterwilsoncc, rajinsharwar, SergeyBiryukov.
Fixes #50163.
See meta#5184.

File:

• trunk/src/wp-includes/class-wp.php (modified) (1 diff)

trunk/src/wp-includes/class-wp.php

@@ -748 +748 @@
 
             if ( is_singular() ) {
-                $post = isset( $wp_query->post ) ? $wp_query->post : null;
-                $next = '<!--nextpage-->';
+                $post    = isset( $wp_query->post ) ? $wp_query->post : null;
+                $next    = '<!--nextpage-->';
+                $page_qv = is_front_page() ? 'paged' : 'page';
 
                 // Check for paged content that exceeds the max number of pages.
-                if ( $post && ! empty( $this->query_vars['page'] ) ) {
+                if ( $post && ! empty( $this->query_vars[ $page_qv ] ) ) {
                     // Check if content is actually intended to be paged.
                     if ( str_contains( $post->post_content, $next ) ) {
-                        $page          = trim( $this->query_vars['page'], '/' );
+                        $page          = trim( $this->query_vars[ $page_qv ], '/' );
                         $content_found = (int) $page <= ( substr_count( $post->post_content, $next ) + 1 );
                     } else {