Changeset 59109

Timestamp:

09/27/2024 07:58:49 PM (9 months ago)

Author:

hellofromTonya

Message:

Code Modernization: Fix trigger_error() with E_USER_ERROR deprecation in TestXMLParser::parse().

PHP 8.4 deprecates the use of trigger_errror() with E_USER_ERROR as the error level, as there are a number of gotchas to this way of creating a Fatal Error (finally blocks not executing, destructors not executing).
The recommended replacements are either to use exceptions or to do a hard exit.

As this is a test-only class, do not have to take BC-breaks into account.

Also, as this is a test helper, throwing a exception is the most appropriate solution.

Reference:

• ​https://wiki.php.net/rfc/deprecations_php_8_4#deprecate_passing_e_user_error_to_trigger_error

Follow-up to [25002].

Props jrf.
See #62061.

File:

• trunk/tests/phpunit/includes/utils.php (modified) (1 diff)

trunk/tests/phpunit/includes/utils.php

@@ -305 +305 @@
         $parse = xml_parse( $this->xml, $in, true );
         if ( ! $parse ) {
-            trigger_error(
+            throw new Exception(
                 sprintf(
                     'XML error: %s at line %d',
                     xml_error_string( xml_get_error_code( $this->xml ) ),
                     xml_get_current_line_number( $this->xml )
-                ),
-                E_USER_ERROR
+                )
             );
             xml_parser_free( $this->xml );