Changeset 59147 for trunk/src/wp-admin/includes/class-wp-debug-data.php

Timestamp:

10/01/2024 01:10:38 AM (23 months ago)

Author:

jorbin

Message:

Site Health: Note when DB_COLLATE is defined but empty.

Right now, for example if DB_COLLATE is defined as , the value will not be shown in the WordPress Constants list, there's just an empty space. This adds a message so it's clearer when the constant is empty.

Props Presskopp, brobken, Clorith.
Fixes #58265.

File:

• trunk/src/wp-admin/includes/class-wp-debug-data.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-debug-data.php

@@ -1339 +1339 @@
                 }
 
+                // Check DB_COLLATE.
+                if ( defined( 'DB_COLLATE' ) && DB_COLLATE ) {
+                        $wp_db_collate = DB_COLLATE;
+                } elseif ( defined( 'DB_COLLATE' ) && empty( DB_COLLATE ) ) {
+                        $wp_db_collate = __( 'Defined, but empty' );
+                } else {
+                        $wp_db_collate = __( 'Undefined' );
+                }
+
                 $fields = array(
                         'ABSPATH'             => array(
@@ -1428 +1437 @@
                         'DB_COLLATE'          => array(
                                 'label' => 'DB_COLLATE',
-                                'value' => ( defined( 'DB_COLLATE' ) ? DB_COLLATE : __( 'Undefined' ) ),
-                                'debug' => ( defined( 'DB_COLLATE' ) ? DB_COLLATE : 'undefined' ),
+                                'value' => $wp_db_collate,
+                                'debug' => $wp_db_collate,
                         ),
                 );