Changeset 59727 for trunk

Timestamp:

01/29/2025 05:38:49 PM (21 months ago)

Author:

joedolson

Message:

Administration: Fix pagination in categories, tags, and plugins tables.

Fix an issue introduced in [59134] that prevented manual entry of a page number in the pagination input field from navigating pages. Requiring validation of the bulk actions input also impacted other inputs nested in the same form.

Also fixes a pre-existing bug where it was not possible to navigate to page 1 using the input field.

Props ffffelix, im3dabasia1, apermo, rishavdutta, joedolson, swissspidy, jorbin, joedolson.
Fixes #62534.

Location:

trunk/src

Files:

• js/_enqueues/admin/common.js (modified) (1 diff)
• wp-admin/edit-tags.php (modified) (1 diff)

trunk/src/js/_enqueues/admin/common.js

@@ -1311 +1311 @@
         };
 
+        // Stores initial pagination value for comparison.
+        var initialPagedValue = document.querySelector( '#current-page-selector' ).value;
+
         $( '.bulkactions' ).parents( 'form' ).on( 'submit', function( event ) {
                 var form = this,
                         submitterName = event.originalEvent && event.originalEvent.submitter ? event.originalEvent.submitter.name : false;
+
+                var currentPagedValue = form.querySelector( '#current-page-selector' ).value;
+
+                if ( initialPagedValue !== currentPagedValue ) {
+                        return; // Pagination form submission.
+                }
 
                 // Observe submissions from posts lists for 'bulk_action' or users lists for 'new_role'.

trunk/src/wp-admin/edit-tags.php

@@ -216 +216 @@
         if ( $pagenum > 1 ) {
                 $location = add_query_arg( 'paged', $pagenum, $location ); // $pagenum takes care of $total_pages.
+        }
+        if ( 1 === $pagenum ) {
+                $location = remove_query_arg( 'paged', $location );
         }