Changeset 59960

Timestamp:

03/10/2025 06:14:48 PM (less than one hour ago)

Author:

joedolson

Message:

Administration: Update out of date error message styling.

Change several error message across core to use WordPress standard styling. Ensure only prefixes are wrapped in strong tags rather than the whole message, use notice notice-error classes where appropriate, and replace a custom error with wp_admin_notice() in multisite.

Props afercia, rajinsharwar, robinmartijn, mukesh27, sabernhardt, oglekler, joedolson, chaion07, im3dabasia1, audrasjb, dkarfa, najmulsaju.
Fixes #50402.

Location:

trunk/src

Files:

• js/_enqueues/admin/tags.js (modified) (1 diff)
• js/_enqueues/vendor/plupload/handlers.js (modified) (1 diff)
• js/_enqueues/wp/theme.js (modified) (1 diff)
• wp-admin/includes/class-wp-ms-themes-list-table.php (modified) (1 diff)
• wp-admin/includes/network.php (modified) (1 diff)
• wp-admin/themes.php (modified) (1 diff)
• wp-signup.php (modified) (1 diff)

trunk/src/js/_enqueues/admin/tags.js

@@ -56 +56 @@
 
                 } else if ( '-1' == r ) {
-                    $('#ajax-response').empty().append('<div class="error"><p>' + wp.i18n.__( 'Sorry, you are not allowed to do that.' ) + '</p></div>');
+                    $('#ajax-response').empty().append('<div class="notice notice-error"><p>' + wp.i18n.__( 'Sorry, you are not allowed to do that.' ) + '</p></div>');
                     tr.children().css('backgroundColor', '');
 
                 } else {
-                    $('#ajax-response').empty().append('<div class="error"><p>' + wp.i18n.__( 'An error occurred while processing your request. Please try again later.' ) + '</p></div>');
+                    $('#ajax-response').empty().append('<div class="notice notice-error"><p>' + wp.i18n.__( 'An error occurred while processing your request. Please try again later.' ) + '</p></div>');
                     tr.children().css('backgroundColor', '');
                 }

trunk/src/js/_enqueues/vendor/plupload/handlers.js

@@ -205 +205 @@
 // Generic error message.
 function wpQueueError( message ) {
-    jQuery( '#media-upload-error' ).show().html( '<div class="error"><p>' + message + '</p></div>' );
+    jQuery( '#media-upload-error' ).show().html( '<div class="notice notice-error"><p>' + message + '</p></div>' );
 }
 

trunk/src/js/_enqueues/wp/theme.js

@@ -1666 +1666 @@
             $( 'body' ).removeClass( 'loading-content' );
             $( '.theme-browser' ).find( 'div.error' ).remove();
-            $( '.theme-browser' ).find( 'div.themes' ).before( '<div class="error"><p>' + l10n.error + '</p><p><button class="button try-again">' + l10n.tryAgain + '</button></p></div>' );
+            $( '.theme-browser' ).find( 'div.themes' ).before( '<div class="notice notice-error"><p>' + l10n.error + '</p><p><button class="button try-again">' + l10n.tryAgain + '</button></p></div>' );
             $( '.theme-browser .error .try-again' ).on( 'click', function( e ) {
                 e.preventDefault();

trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php

@@ -705 +705 @@
 
         if ( $theme->errors() ) {
-            $pre = 'broken' === $status ? __( 'Broken Theme:' ) . ' ' : '';
-            echo '<p><strong class="error-message">' . $pre . $theme->errors()->get_error_message() . '</strong></p>';
+            $pre = 'broken' === $status ? '<strong class="error-message">' . __( 'Broken Theme:' ) . '</strong> ' : '';
+            wp_admin_notice(
+                $pre . $theme->errors()->get_error_message(),
+                array(
+                    'type'               => 'error',
+                    'additional_classes' => 'inline',
+                )
+            );
         }
 

trunk/src/wp-admin/includes/network.php

@@ -159 +159 @@
     $error_codes = array();
     if ( is_wp_error( $errors ) ) {
-        $network_created_error_message = '<p><strong>' . __( 'Error: The network could not be created.' ) . '</strong></p>';
+        $network_created_error_message = '<p><strong>' . __( 'Error:' ) . '</strong> ' . __( 'The network could not be created.' ) . '</p>';
         foreach ( $errors->get_error_messages() as $error ) {
             $network_created_error_message .= "<p>$error</p>";

trunk/src/wp-admin/themes.php

@@ -346 +346 @@
 if ( $current_theme->errors() && ( ! is_multisite() || current_user_can( 'manage_network_themes' ) ) ) {
     wp_admin_notice(
-        __( 'Error:' ) . ' ' . $current_theme->errors()->get_error_message(),
+        '<strong>' . __( 'Error:' ) . '</strong> ' . $current_theme->errors()->get_error_message(),
         array(
             'additional_classes' => array( 'error' ),

trunk/src/wp-signup.php

@@ -69 +69 @@
         .mu_register fieldset,
             .mu_register legend { margin: 0; padding: 0; border: none; }
-        .mu_register .error { font-weight: 600; padding: 10px; color: #333; background: #ffebe8; border: 1px solid #c00; }
+        .mu_register .error { padding: 10px; color: #333; background: #ffebe8; border: 1px solid #c00; }
         .mu_register input[type="submit"],
             .mu_register #blog_title,