Changeset 60447 for trunk/src/wp-includes/rewrite.php

Timestamp:

07/11/2025 01:14:57 PM (10 days ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Remove redundant checks in wp_resolve_numeric_slug_conflicts().

This commit removes two unnecessary conditional checks:

• A truthy check for $compare, as a falsey value causes an earlier return a few lines above.
• A check to ensure $maybe_page is not an empty string, as it is already cast to an integer.

Follow-up to [32648], [34492], [53857].

Props justlevine.
See #63268.

File:

• trunk/src/wp-includes/rewrite.php (modified) (2 diffs)

trunk/src/wp-includes/rewrite.php

@@ -413 +413 @@
     // This is the potentially clashing slug.
     $value = '';
-    if ( $compare && array_key_exists( $compare, $query_vars ) ) {
+    if ( array_key_exists( $compare, $query_vars ) ) {
         $value = $query_vars[ $compare ];
     }
@@ -461 +461 @@
 
     // If we've gotten to this point, we have a slug/date clash. First, adjust for nextpage.
-    if ( '' !== $maybe_page ) {
-        $query_vars['page'] = (int) $maybe_page;
-    }
+    $query_vars['page'] = $maybe_page;
 
     // Next, unset autodetected date-related query vars.