Changeset 60805 for trunk/src/wp-admin/options-general.php

Timestamp:

09/28/2025 10:36:30 PM (2 months ago)

Author:

joedolson

Message:

I18n: Combine duplicate text strings into variables.

In cases where a string is used both for a visible label and a screen reader text label, the screen reader text should never be different from the visible label. To help ensure this doesn't happen, use only a single string. The associated screen reader text comments are no longer required.

This is also true for a few cases where there are strings in contexts where variables can't be used. In these cases, the screen reader text comments are also removed.

Props sabernhardt, swissspidy, audrasjb, joedolson.
Fixes #63620.

File:

• trunk/src/wp-admin/options-general.php (modified) (3 diffs)

trunk/src/wp-admin/options-general.php

@@ -290 +290 @@
 </tr>
 
-<?php if ( ! is_multisite() ) { ?>
-
-<tr>
-<th scope="row"><?php _e( 'Membership' ); ?></th>
-<td> <fieldset><legend class="screen-reader-text"><span>
-    <?php
-    /* translators: Hidden accessibility text. */
-    _e( 'Membership' );
-    ?>
-</span></legend><label for="users_can_register">
+<?php
+if ( ! is_multisite() ) {
+    $membership_title = __( 'Membership' );
+    ?>
+<tr>
+<th scope="row"><?php echo $membership_title; ?></th>
+<td><fieldset><legend class="screen-reader-text"><span><?php echo $membership_title; ?></span></legend><label for="users_can_register">
 <input name="users_can_register" type="checkbox" id="users_can_register" value="1" <?php checked( '1', get_option( 'users_can_register' ) ); ?> />
     <?php _e( 'Anyone can register' ); ?></label>
@@ -460 +457 @@
 <?php endif; ?>
 </td>
-
-</tr>
-<tr>
-<th scope="row"><?php _e( 'Date Format' ); ?></th>
+</tr>
+
+<?php $date_format_title = __( 'Date Format' ); ?>
+<tr>
+<th scope="row"><?php echo $date_format_title; ?></th>
 <td>
-    <fieldset><legend class="screen-reader-text"><span>
-        <?php
-        /* translators: Hidden accessibility text. */
-        _e( 'Date Format' );
-        ?>
-    </span></legend>
+    <fieldset><legend class="screen-reader-text"><span><?php echo $date_format_title; ?></span></legend>
 <?php
     /**
@@ -512 +505 @@
 </td>
 </tr>
-<tr>
-<th scope="row"><?php _e( 'Time Format' ); ?></th>
+
+<?php $time_format_title = __( 'Time Format' ); ?>
+<tr>
+<th scope="row"><?php echo $time_format_title; ?></th>
 <td>
-    <fieldset><legend class="screen-reader-text"><span>
-        <?php
-        /* translators: Hidden accessibility text. */
-        _e( 'Time Format' );
-        ?>
-    </span></legend>
+    <fieldset><legend class="screen-reader-text"><span><?php echo $time_format_title; ?></span></legend>
 <?php
     /**