Make WordPress Core

Changeset 61094


Ignore:
Timestamp:
10/30/2025 06:22:07 PM (7 days ago)
Author:
joedolson
Message:

Twenty Thirteen: Fix post navigation to respect sort order.

Change the labels on post navigation links when the sort order is changed so the labels accurately reflect the target entries.

Previously, if the sort order was reversed, 'Older' or 'Previous' links would navigate to newer entries and 'Newer' or 'Next' links would navigate to older entries.

Props jikamens, dancameron, obenland, shrey0shrivastava, sirlouen, sabernhardt, shailu25, westonruter, joedolson.
See #10219.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-content/themes/twentythirteen/functions.php

    r60962 r61094  
    495495            return;
    496496        }
     497
     498        $order   = get_query_var( 'order', 'DESC' );
     499        $is_desc = 'DESC' === $order;
     500
     501        $new_posts_text = __( 'Newer posts <span class="meta-nav">&rarr;</span>', 'twentythirteen' );
     502        $old_posts_text = __( '<span class="meta-nav">&larr;</span> Older posts', 'twentythirteen' );
     503
     504        $prev_link = $is_desc ? get_next_posts_link( $old_posts_text ) : get_previous_posts_link( $old_posts_text );
     505        $next_link = $is_desc ? get_previous_posts_link( $new_posts_text ) : get_next_posts_link( $new_posts_text );
    497506        ?>
     507
    498508        <nav class="navigation paging-navigation">
    499509        <h1 class="screen-reader-text">
     
    504514        </h1>
    505515        <div class="nav-links">
    506 
    507             <?php if ( get_next_posts_link() ) : ?>
    508             <div class="nav-previous"><?php next_posts_link( __( '<span class="meta-nav">&larr;</span> Older posts', 'twentythirteen' ) ); ?></div>
    509             <?php endif; ?>
    510 
    511             <?php if ( get_previous_posts_link() ) : ?>
    512             <div class="nav-next"><?php previous_posts_link( __( 'Newer posts <span class="meta-nav">&rarr;</span>', 'twentythirteen' ) ); ?></div>
    513             <?php endif; ?>
     516        <?php if ( $prev_link ) : ?>
     517            <div class="nav-previous">
     518                <?php echo $prev_link; ?>
     519            </div>
     520            <?php
     521        endif;
     522
     523        if ( $next_link ) :
     524            ?>
     525            <div class="nav-next">
     526                <?php echo $next_link; ?>
     527            </div>
     528        <?php endif; ?>
    514529
    515530        </div><!-- .nav-links -->
Note: See TracChangeset for help on using the changeset viewer.