Changeset 61632 for trunk/src/wp-includes/class-wp-theme-json.php

Timestamp:

02/13/2026 01:51:03 AM (7 weeks ago)

Author:

ramonopoly

Message:

Block Supports: Add text indent to typography supports

This commit adds CSS text-indent support for paragraph blocks with traditional typography conventions - subsequent paragraphs get first-line indented in LTR languages, with an option to indent all paragraphs (default for RTL languages).

Text indentation is a fundamental typography feature. Traditional print typography conventions dictate that only subsequent paragraphs (not the first) should have their first line indented in LTR languages, while RTL languages typically indent all paragraphs. This feature enables proper typographic styling that matches publishing standards.

Props aaronrobertshaw, ramonopoly, andrewserong, wildworks, matveb, skorasaurus, greenshady, kjellr.

Fixes #64326.

File:

• trunk/src/wp-includes/class-wp-theme-json.php (modified) (8 diffs)

trunk/src/wp-includes/class-wp-theme-json.php

@@ -248 +248 @@
      * @since 6.7.0 Added `background-attachment` property.
      * @since 7.0.0 Added `dimensions.width` and `dimensions.height`.
+     *              Added `text-indent` property.
      * @var array
      */
@@ -310 +311 @@
         'text-decoration'                   => array( 'typography', 'textDecoration' ),
         'text-transform'                    => array( 'typography', 'textTransform' ),
+        'text-indent'                       => array( 'typography', 'textIndent' ),
         'filter'                            => array( 'filter', 'duotone' ),
         'box-shadow'                        => array( 'shadow' ),
@@ -410 +412 @@
      * @since 7.0.0 Added type markers to the schema for boolean values.
      *              Added support for `dimensions.width` and `dimensions.height`.
+     *              Added support for `typography.textIndent`.
      * @var array
      */
@@ -495 +498 @@
             'textColumns'      => null,
             'textDecoration'   => null,
+            'textIndent'       => null,
             'textTransform'    => null,
             'writingMode'      => null,
@@ -602 +606 @@
             'textColumns'    => null,
             'textDecoration' => null,
+            'textIndent'     => null,
             'textTransform'  => null,
             'writingMode'    => null,
@@ -2751 +2756 @@
 
     /**
+     * Updates the text indent selector for paragraph blocks based on the textIndent setting.
+     *
+     * The textIndent setting can be 'subsequent' (default), 'all', or false.
+     * When set to 'all', the selector should be '.wp-block-paragraph' instead of
+     * '.wp-block-paragraph + .wp-block-paragraph' to apply indent to all paragraphs.
+     *
+     * @since 7.0.0
+     *
+     * @param array  $feature_declarations The feature declarations keyed by selector.
+     * @param array  $settings             The theme.json settings.
+     * @param string $block_name           The block name being processed.
+     * @return array The updated feature declarations.
+     */
+    private static function update_paragraph_text_indent_selector( $feature_declarations, $settings, $block_name ) {
+        if ( 'core/paragraph' !== $block_name ) {
+            return $feature_declarations;
+        }
+
+        // Check block-level settings first, then fall back to global settings.
+        $block_settings      = $settings['blocks']['core/paragraph'] ?? null;
+        $text_indent_setting = $block_settings['typography']['textIndent']
+            ?? $settings['typography']['textIndent']
+            ?? 'subsequent';
+
+        if ( 'all' !== $text_indent_setting ) {
+            return $feature_declarations;
+        }
+
+        // Look for the text indent selector and replace it.
+        $old_selector = '.wp-block-paragraph + .wp-block-paragraph';
+        $new_selector = '.wp-block-paragraph';
+
+        if ( isset( $feature_declarations[ $old_selector ] ) ) {
+            $declarations = $feature_declarations[ $old_selector ];
+            unset( $feature_declarations[ $old_selector ] );
+            $feature_declarations[ $new_selector ] = $declarations;
+        }
+
+        return $feature_declarations;
+    }
+
+    /**
      * An internal method to get the block nodes from a theme.json file.
      *
@@ -2911 +2958 @@
         $is_root_selector     = static::ROOT_BLOCK_SELECTOR === $selector;
 
+        // Update text indent selector for paragraph blocks based on the textIndent setting.
+        $block_name           = $block_metadata['name'] ?? null;
+        $feature_declarations = static::update_paragraph_text_indent_selector( $feature_declarations, $settings, $block_name );
+
         // If there are style variations, generate the declarations for them, including any feature selectors the block may have.
         $style_variation_declarations    = array();
@@ -2922 +2973 @@
                 // Generate any feature/subfeature style declarations for the current style variation.
                 $variation_declarations = static::get_feature_declarations_for_node( $block_metadata, $style_variation_node );
+
+                // Update text indent selector for paragraph blocks based on the textIndent setting.
+                $variation_declarations = static::update_paragraph_text_indent_selector( $variation_declarations, $settings, $block_name );
 
                 // Combine selectors with style variation's selector and add to overall style variation declarations.