Changeset 61656 for trunk/src/wp-includes/user.php

Timestamp:

02/17/2026 05:48:04 AM (6 weeks ago)

Author:

westonruter

Message:

Users: Ensure user data supplied to wp_insert_user() is normalized to an array.

This fixes an issue where PHPStan hangs when analyzing the containing users.php file.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/10953

Follow-up to [60650].

Props westonruter, justlevine, peterwilsoncc.
See #64238, #61175.

File:

• trunk/src/wp-includes/user.php (modified) (2 diffs)

trunk/src/wp-includes/user.php

@@ -2210 +2210 @@
     } elseif ( $userdata instanceof WP_User ) {
         $userdata = $userdata->to_array();
+    } elseif ( $userdata instanceof Traversable ) {
+        $userdata = iterator_to_array( $userdata );
+    } elseif ( $userdata instanceof ArrayAccess ) {
+        $userdata_obj = $userdata;
+        $userdata     = array();
+        foreach (
+            array(
+                'ID',
+                'user_pass',
+                'user_login',
+                'user_nicename',
+                'user_url',
+                'user_email',
+                'display_name',
+                'nickname',
+                'first_name',
+                'last_name',
+                'description',
+                'rich_editing',
+                'syntax_highlighting',
+                'comment_shortcuts',
+                'admin_color',
+                'use_ssl',
+                'user_registered',
+                'user_activation_key',
+                'spam',
+                'show_admin_bar_front',
+                'role',
+                'locale',
+                'meta_input',
+            ) as $key
+        ) {
+            if ( isset( $userdata_obj[ $key ] ) ) {
+                $userdata[ $key ] = $userdata_obj[ $key ];
+            }
+        }
+    } else {
+        $userdata = (array) $userdata;
     }
 
@@ -2245 +2283 @@
     }
 
-    $sanitized_user_login = sanitize_user( $userdata['user_login'], true );
+    $sanitized_user_login = sanitize_user( $userdata['user_login'] ?? '', true );
 
     /**