Changeset 62347 for trunk/src/wp-includes/class-wp-theme-json.php

Timestamp:

05/11/2026 02:04:05 AM (5 months ago)

Author:

ramonopoly

Message:

WP_Theme_JSON: Prevent implicit coercion in to_ruleset

to_ruleset used string concatenation ($element['name'] . ': ' . $element['value'] . ';'), so PHP implicitly coerced non-string values (e.g. booleans → '1'/'', arrays → 'Array'). That could emit invalid or misleading CSS.

At the same time, pass a style theme.json path in test_get_styles_with_appearance_tools() to simulate a style node. Before it was settings.

Props ramonopoly, andrewserong, isabel_brison.

Fixes #64848.

--This line, and those below, will be ignored--

M src/wp-includes/class-wp-theme-json.php
M tests/phpunit/tests/theme/wpThemeJson.php

File:

• trunk/src/wp-includes/class-wp-theme-json.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-theme-json.php

@@ -1983 +1983 @@
          *
          * @since 5.8.0
+         * @since 7.1.0 Skip declarations whose value is not a plain string (booleans, arrays, objects, etc.).
          *
          * @param string $selector     CSS selector.
@@ -1996 +1997 @@
                         $declarations,
                         static function ( $carry, $element ) {
-                                return $carry .= $element['name'] . ': ' . $element['value'] . ';'; },
+                                $value = $element['value'];
+
+                                if ( is_numeric( $value ) ) {
+                                        $value = (string) $value;
+                                }
+
+                                if ( ! is_string( $value ) ) {
+                                        return $carry;
+                                }
+
+                                return $carry .= $element['name'] . ': ' . $value . ';';
+                        },
                         ''
                 );