Changeset 62700 for trunk/src/wp-includes/class-wp-theme-json.php

Timestamp:

07/13/2026 01:41:59 AM (7 weeks ago)

Author:

ramonopoly

Message:

Block Style Variations: Simplify block style variation selector regex

The existing regex's first capture group is effectively dead. It only matched a literal :(...), which isn't valid selector syntax (functional pseudo-classes like :is() and :where() always have a name between the colon and the parenthesis), so $matches[1] is always empty.

The second group did all the work, so dropping the dead group gives identical output and is much easier to understand.

Props aaronrobertshaw, andrewserong, ramonopoly, wildworks.

Fixes #65588.

File:

• trunk/src/wp-includes/class-wp-theme-json.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-theme-json.php

@@ -5663 +5663 @@
                 $result         = array();
 
+                /*
+                 * Append the variation class to each selector's ancestor: the first
+                 * run of characters before any combinator (whitespace) or pseudo-class
+                 * (`:`). Only the first match is replaced.
+                 *
+                 * Examples ("custom" variation):
+                 * - `.wp-block`              => `.wp-block.is-style-custom`
+                 * - `.wp-block .inner`       => `.wp-block.is-style-custom .inner`
+                 * - `.wp-block:where(.a .b)` => `.wp-block.is-style-custom:where(.a .b)`
+                 * - `:where(.outer .inner)`  => `:where(.outer.is-style-custom .inner)`
+                 */
                 foreach ( $selector_parts as $part ) {
                         $result[] = preg_replace_callback(
-                                '/((?::\([^)]+\))?\s*)([^\s:]+)/',
+                                '/[^\s:]+/',
                                 function ( $matches ) use ( $variation_class ) {
-                                        return $matches[1] . $matches[2] . $variation_class;
+                                        return $matches[0] . $variation_class;
                                 },
                                 $part,