Changeset 63509 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php

Timestamp:

09/06/2026 06:38:39 PM (13 hours ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Use the null coalescing assignment operator for default value assignments.

Replaces verbose "assign a default only if not already set" patterns with the null coalescing assignment operator (??=):

// Before
$args['title'] = $args['title'] ?? '';

// After
$args['title'] ??= '';

Both forms are functionally identical; ??= is shorter and clearer.

Why this is safe

• ??= requires PHP 7.4, which is already the minimum.
• The operator is already used elsewhere in core (e.g. wp-includes/l10n.php, wp-includes/view-config.php), so this only makes existing usage consistent.
• No behavior change.

Follow-up to r63443, r63501.

Props Soean, mukesh27.
See #65823.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php (modified) (4 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php

@@ -1292 +1292 @@
 
                 // Set new attachment post title with fallbacks.
-                $new_attachment_post->post_title = $new_attachment_post->post_title ?? $original_attachment_post->post_title ?? $image_name;
+                $new_attachment_post->post_title ??= $original_attachment_post->post_title ?? $image_name;
 
                 // Set new attachment post caption (post_excerpt).
-                $new_attachment_post->post_excerpt = $new_attachment_post->post_excerpt ?? $original_attachment_post->post_excerpt ?? '';
+                $new_attachment_post->post_excerpt ??= $original_attachment_post->post_excerpt ?? '';
 
                 // Set new attachment post description (post_content) with fallbacks.
-                $new_attachment_post->post_content = $new_attachment_post->post_content ?? $original_attachment_post->post_content ?? '';
+                $new_attachment_post->post_content ??= $original_attachment_post->post_content ?? '';
 
                 // Set post parent if set in request, else the default of `0` (no parent).
-                $new_attachment_post->post_parent = $new_attachment_post->post_parent ?? 0;
+                $new_attachment_post->post_parent ??= 0;
 
                 // Insert the new attachment post.
@@ -1526 +1526 @@
                                 }
 
-                                $metadata['sizes'] = $metadata['sizes'] ?? array();
+                                $metadata['sizes'] ??= array();
 
                                 $fallback_sizes = array(
@@ -3300 +3300 @@
                                 }
 
-                                $metadata['sizes'] = $metadata['sizes'] ?? array();
+                                $metadata['sizes'] ??= array();
 
                                 foreach ( $image_size as $name ) {
@@ -3385 +3385 @@
                                 }
 
-                                $metadata['sizes'] = $metadata['sizes'] ?? array();
+                                $metadata['sizes'] ??= array();
 
                                 $metadata['sizes'][ $image_size ] = array(