Changeset 64347 for trunk/src/wp-includes/functions.php

Timestamp:

10/14/2026 07:34:43 PM (43 hours ago)

Author:

joedolson

Message:

Admin: Revert admin notices accessibility fixes.

Following merge, it became evident that the complexity of notices as handled in the WordPress admin make this change premature. While it worked effectively handling standard notices, there are significant numbers of unusual notice cases. The follow-up PR (​https://github.com/wordpress/wordpress-develop/pull/14223) would have significantly limited the false positives, but not sufficiently for production.

Variant notices will need to have improved handling before these fixes can be implemented effectively.

Props joedolson, matt, peterwilsoncc, wildworks, mamaduka.
See #50486.

File:

• trunk/src/wp-includes/functions.php (modified) (2 diffs)

trunk/src/wp-includes/functions.php

@@ -9346 +9346 @@
         $args = apply_filters( 'wp_admin_notice_args', $args, $message );
 
-        // Unique ID is intended for internal use, and is not a filterable argument.
-        $unique_id         = wp_unique_prefixed_id( 'wp-admin-notice-' );
-        $args['notice_id'] = $unique_id;
-
         $wrap_with_p  = false !== $args['paragraph_wrap'];
         $wrap_opener  = $wrap_with_p ? '<p>' : '';
@@ -9359 +9355 @@
                 $trimmed_id = trim( $args['id'] );
 
-                $html_builder->set_attribute( 'data-id', $unique_id );
                 if ( '' !== $trimmed_id ) {
                         $html_builder->set_attribute( 'id', $trimmed_id );
-                } else {
-                        $html_builder->set_attribute( 'id', $unique_id );
-                }
-        } else {
-                $html_builder->set_attribute( 'data-id', $unique_id );
-                $html_builder->set_attribute( 'id', $unique_id );
+                }
         }