Changeset 64690

Timestamp:

10/23/2026 05:58:31 PM (5 hours ago)

Author:

westonruter

Message:

Code Modernization: Use array_any() and array_all() more widely.

This replaces foreach loops that return early on the first matching or failing element with array_any() and array_all(), with no change in behavior. These loops were all added in later features, so they were missed by the conversions in r62550 and r62553.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/14618.
Follow-up to r59783, r62550, r62553, r62564, r63453, r64337, r64351, r64388, r64402, r64500, r64588.

Props soean.
See #65818.

Location:

trunk/src

Files:

• wp-admin/includes/plugin.php (modified) (1 diff)
• wp-includes/abilities-api/class-wp-ability.php (modified) (1 diff)
• wp-includes/abilities/class-wp-abilities-content.php (modified) (2 diffs)
• wp-includes/class-wp-rewrite.php (modified) (1 diff)
• wp-includes/media.php (modified) (1 diff)
• wp-includes/secrets/class-wp-secrets-config-key-provider.php (modified) (1 diff)

trunk/src/wp-admin/includes/plugin.php

@@ -2206 +2206 @@
         }
 
-        foreach ( (array) $_wp_submenu_nopriv as $nopriv_submenus ) {
-                if ( isset( $nopriv_submenus[ $plugin_page ] ) ) {
-                        return true;
-                }
-        }
-
-        return false;
+        return array_any(
+                (array) $_wp_submenu_nopriv,
+                fn( $nopriv_submenus ) => isset( $nopriv_submenus[ $plugin_page ] )
+        );
 }
 

trunk/src/wp-includes/abilities-api/class-wp-ability.php

@@ -642 +642 @@
                 }
 
-                foreach ( $capabilities as $capability ) {
-                        if ( ! is_string( $capability ) || '' === trim( $capability ) ) {
-                                return false;
-                        }
-                }
-                return true;
+                return array_all(
+                        $capabilities,
+                        fn( $capability ) => is_string( $capability ) && '' !== trim( $capability )
+                );
         }
 

trunk/src/wp-includes/abilities/class-wp-abilities-content.php

@@ -283 +283 @@
          */
         private function can_query_statuses( array $where, WP_Post_Type $post_type_object ): bool {
-                foreach ( $this->get_requested_statuses( $where ) as $status ) {
-                        if ( ! $this->can_query_status( $status, $post_type_object ) ) {
-                                return false;
-                        }
-                }
-
-                return true;
+                return array_all(
+                        $this->get_requested_statuses( $where ),
+                        fn( $status ) => $this->can_query_status( $status, $post_type_object )
+                );
         }
 
@@ -791 +788 @@
          */
         private function should_prime_post_caches( array $fields ): bool {
-                foreach ( self::CACHE_PRIMING_FIELDS as $field ) {
-                        if ( $this->is_field_requested( $field, $fields ) ) {
-                                return true;
-                        }
-                }
-
-                return false;
+                return array_any(
+                        self::CACHE_PRIMING_FIELDS,
+                        fn( $field ) => $this->is_field_requested( $field, $fields )
+                );
         }
 

trunk/src/wp-includes/class-wp-rewrite.php

@@ -1560 +1560 @@
                 }
 
-                $random_base_is_taken = false;
-                foreach ( $random_base_posts as $random_base_post ) {
-                        if ( $random_base_post instanceof WP_Post && is_post_publicly_viewable( $random_base_post ) ) {
-                                $random_base_is_taken = true;
-                                break;
-                        }
-                }
+                $random_base_is_taken = array_any(
+                        $random_base_posts,
+                        fn( $random_base_post ) => $random_base_post instanceof WP_Post && is_post_publicly_viewable( $random_base_post )
+                );
 
                 if ( ! $random_base_is_taken ) {

trunk/src/wp-includes/media.php

@@ -7019 +7019 @@
         }
 
-        foreach ( headers_list() as $header ) {
-                if ( 0 === stripos( $header, 'Document-Isolation-Policy:' ) ) {
-                        return true;
-                }
-        }
-
-        return false;
-}
-
+        return array_any(
+                headers_list(),
+                fn( $header ) => 0 === stripos( $header, 'Document-Isolation-Policy:' )
+        );
+}
+

trunk/src/wp-includes/secrets/class-wp-secrets-config-key-provider.php

@@ -262 +262 @@
          */
         private function are_usable_salt_values( $logged_in_key, $logged_in_salt ): bool {
-                foreach ( array( $logged_in_key, $logged_in_salt ) as $value ) {
-                        if ( ! is_string( $value ) || '' === $value || self::KNOWN_PLACEHOLDER === $value ) {
-                                return false;
-                        }
-                }
-
-                return true;
+                return array_all(
+                        array( $logged_in_key, $logged_in_salt ),
+                        fn( $value ) => is_string( $value ) && '' !== $value && self::KNOWN_PLACEHOLDER !== $value
+                );
         }