Changeset 8208 for trunk/wp-admin/theme-editor.php

Timestamp:

06/27/2008 08:14:50 PM (16 years ago)

Author:

ryan

Message:

Check fopen return value. Props Otto42 and pishmishy. fixes #4448

File:

• trunk/wp-admin/theme-editor.php (modified) (1 diff)

trunk/wp-admin/theme-editor.php

@@ -44 +44 @@
     $theme = urlencode($theme);
     if (is_writeable($real_file)) {
+        //is_writable() not always reliable, check return value. see comments @ http://uk.php.net/is_writable
         $f = fopen($real_file, 'w+');
-        fwrite($f, $newcontent);
-        fclose($f);
-        $location = "theme-editor.php?file=$file&theme=$theme&a=te";
+        if ($f !== FALSE) {
+            fwrite($f, $newcontent);
+            fclose($f);
+            $location = "theme-editor.php?file=$file&theme=$theme&a=te";
+        } else {
+            $location = "theme-editor.php?file=$file&theme=$theme";
+        }
     } else {
         $location = "theme-editor.php?file=$file&theme=$theme";