Changeset 8358 for trunk/wp-admin/includes/media.php

Timestamp:

07/16/2008 09:36:17 PM (17 years ago)

Author:

azaozz

Message:

Removes the disabling of captions, but leaves couple of hooks so a plugin can do it easily. see #6812

File:

• trunk/wp-admin/includes/media.php (modified) (8 diffs)

trunk/wp-admin/includes/media.php

@@ -68 +68 @@
 function image_add_caption( $html, $id, $alt, $title, $align, $url, $size ) {
 
-    // CAPTIONS_OFF is temporary. Do not use it.
-    if ( empty($alt) || ( defined('CAPTIONS_OFF') && true == CAPTIONS_OFF ) ) return $html;
+    if ( empty($alt) || apply_filters( 'disable_captions', '' ) ) return $html;
     $id = ( 0 < (int) $id ) ? 'attachment_' . $id : '';
 
@@ -511 +510 @@
         $form_fields['post_title']['required'] = true;
 
-        // CAPTIONS_OFF is temporary. Do not use it.
-        if ( defined('CAPTIONS_OFF') && true == CAPTIONS_OFF ) {
-            $form_fields['post_excerpt']['label'] = __('Alternate Text');
-            $form_fields['post_excerpt']['helps'][] = __('Alt text for the image, e.g. "The Mona Lisa"');
-        } else {
-            $form_fields['post_excerpt']['label'] = __('Caption');
-            $form_fields['post_excerpt']['helps'][] = __('Also used as alternate text for the image');
-        }
+        $form_fields['post_excerpt']['label'] = __('Caption');
+        $form_fields['post_excerpt']['helps'][] = __('Also used as alternate text for the image');
 
         $form_fields['post_content']['label'] = __('Description');
@@ -607 +600 @@
     $link = get_attachment_link($post->ID);
 
-    // CAPTIONS_OFF is temporary. Do not use it.
-    if ( defined('CAPTIONS_OFF') && true == CAPTIONS_OFF )
-        $alt = __('Alternate Text');
-    else
-        $alt = __('Caption');
-
     $form_fields = array(
         'post_title'   => array(
@@ -619 +606 @@
         ),
         'post_excerpt' => array(
-            'label'      => $alt,
+            'label'      => __('Caption'),
             'value'      => $edit_post->post_excerpt,
         ),
@@ -1022 +1009 @@
         if ( f.alt.value ) {
             alt = f.alt.value.replace(/['"<>]+/g, '');
-<?php if ( ! defined('CAPTIONS_OFF') || true != CAPTIONS_OFF ) { // CAPTIONS_OFF is temporary. Do not use it. ?>
+<?php if ( ! apply_filters( 'disable_captions', '' ) ) { ?>
             caption = f.alt.value.replace(/'/g, '&#39;').replace(/"/g, '&quot;').replace(/</g, '&lt;').replace(/>/g, '&gt;');
 <?php } ?>
@@ -1279 +1266 @@
 
 function type_form_image() {
-    $form = '
+
+    if ( apply_filters( 'disable_captions', '' ) ) {
+        $alt = __('Alternate Text');
+        $alt_help = __('Alt text for the image, e.g. "The Mona Lisa"');
+    } else {
+        $alt = __('Image Caption');
+        $alt_help = __('Also used as alternate text for the image');
+    }
+    
+    return '
     <table class="describe"><tbody>
         <tr>
@@ -1296 +1292 @@
             <td class="field"><p><input id="title" name="title" value="" type="text" aria-required="true" /></p></td>
         </tr>
-';
-    // CAPTIONS_OFF is temporary. Do not use it.
-    if ( defined('CAPTIONS_OFF') && true == CAPTIONS_OFF ) {
-        $form .= '
+
         <tr>
             <th valign="top" scope="row" class="label">
-                <span class="alignleft"><label for="alt">' . __('Alternate Text') . '</label></span>
+                <span class="alignleft"><label for="alt">' . $alt . '</label></span>
             </th>
             <td class="field"><input id="alt" name="alt" value="" type="text" aria-required="true" />
-            <p class="help">' . __('Alt text for the image, e.g. "The Mona Lisa"') . '</p></td>
-        </tr>
-';
-
-    } else {
-        $form .= '
-        <tr>
-            <th valign="top" scope="row" class="label">
-                <span class="alignleft"><label for="alt">' . __('Image Caption') . '</label></span>
-            </th>
-            <td class="field"><input id="alt" name="alt" value="" type="text" aria-required="true" />
-            <p class="help">' . __('Also used as alternate text for the image') . '</p></td>
-        </tr>
-';
-    }
-        $form .= '
+            <p class="help">' . $alt_help . '</p></td>
+        </tr>
+
         <tr class="align">
             <th valign="top" scope="row" class="label"><p><label for="align">' . __('Alignment') . '</label></p></th>
@@ -1355 +1335 @@
 ';
 
-    return $form;
 }