WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#10849 closed defect (bug) (fixed)

OPML import file size limit

Reported by: yoavf Owned by:
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Import Keywords: has-patch
Focuses: Cc:

Description

The opml import script currently uses a hidden input field of "MAX_FILE_SIZE" to limit the import size (currently 30000 bytes)

  1. This is too small
  2. This is a hidden input field that can overridden with tools like Firebug etc.

Suggestions

  1. Either remove the file size limit and rely on each server file limit.
  2. OR up the file limit (100kb at least) and enforce that in the php script

I can submit a patch for option 2 if that's better.

Attachments (1)

10849.diff (1.0 KB) - added by sivel 6 years ago.
Use wp_max_upload_size and fix a notice for undefined index.

Download all attachments as: .zip

Change History (3)

@sivel6 years ago

Use wp_max_upload_size and fix a notice for undefined index.

comment:1 @sivel6 years ago

  • Keywords has-patch added
  • Milestone changed from Unassigned to 3.0

comment:2 @nacin6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [13306]) Fix notice, and use wp_max_upload_size() to fill MAX_FILE_SIZE hidden field (used by supporting browsers for a client-side check). Fixes #10849 props sivel.

Note: See TracTickets for help on using tickets.