Auto upgrade fails SSH when the file is empty.

[ShaneF]

Upgrade WordPress

Downloading update from ​http://wordpress.org/wordpress-2.8.5.zip.

Unpacking the update.

Could not copy file: /home/bugssite/public_html/wp-content/upgrade/wordpress-2.8.5/wordpress/wp-includes/js/codepress/engines/khtml.js

Installation Failed

[westi]

We really should fix this for 2.9.

Need to dig into the code for the ssh upgrader and work out whats wrong here.

[dd32]

This has been fixed in trunk for awhile now..

​http://core.trac.wordpress.org/browser/trunk/wp-admin/includes/class-wp-filesystem-ssh2.php#L165

2.8.x doesnt include false !==, as it is, the function is returning the number of bytes written under 2.8, whereas, its returning a bool under trunk.

See [11818] Fix class-wp-filesystem-ssh2 put_contents() for empty files, props lostinlafayette dd32, fixes #10604