WordPress.org

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#11511 closed defect (bug) (duplicate)

Page numbers not updated when doing a tag search

Reported by: scribu Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.8
Component: Administration Keywords: has-patch 2nd-opinion
Focuses: Cc:

Description

When you go to wp-admin/edit-tags.php and do a tag search, the pagination links are not updated to reflec that search.

Say if you have 10 pages of tags, in total. If you do a search that finds only 2 tags, you will still see links to those 10 pages.

Attachments (2)

11511.patch (1.1 KB) - added by hakre 11 years ago.
Display problem fix
11511.3.patch (2.1 KB) - added by garyc40 11 years ago.

Download all attachments as: .zip

Change History (10)

#1 @miqrogroove
11 years ago

  • Version changed from 2.9 to 2.8

old bug. I'll check for dupes.

#3 @hakre
11 years ago

Pagination is generated in line 193 of the named file which does not reflect for it's total the total tags returned by the search but for the taxonomy.

the search output can not reflect the pagenumber properly because there is no input ossibility for tag search page count.

(Aditionally: AJAX-Adding tags does not reflect the number of tags per page as well.)

Patch does fix the display problem. It's a cosmetic fix. The underlying problem is that searching for tags is not properly imlemented with pagination in mind (a search for a tag will ever return the number per tags per page at maximum).

@hakre
11 years ago

Display problem fix

#4 @hakre
11 years ago

  • Keywords has-patch added

#5 @hakre
11 years ago

  • Keywords 2nd-opinion added

I'd like to see a second opinion on my patch. I tested it a bit over the last days (it actually does fix the problem which mainly is a display problem). So fix it or close it?

#6 @Denis-de-Bernardy
11 years ago

  • Keywords needs-patch added; has-patch 2nd-opinion removed

the patch breaks pagination when multiple pages of searched terms are returned.

@garyc40
11 years ago

#7 @garyc40
11 years ago

  • Cc garyc40@… added
  • Keywords has-patch 2nd-opinion added; needs-patch removed

In this patch I added an argument for wp_count_terms() so that search keywords are taken into account when counting terms.

#8 @scribu
11 years ago

  • Milestone 3.0 deleted
  • Resolution set to duplicate
  • Status changed from new to closed

This is a dup of #11989.

Note: See TracTickets for help on using tickets.