Media.php validation fix

[Simek]

Remove unneeded empty span from the uploader and the Media Library screen.

[miqrogroove]

Empty span tags do not cause validation errors. This ticket should be closed invalid unless a proper description is added.

[Simek]

additional validation fix - missing FORM close tag added

[Simek]

Replying to miqrogroove:
You have right - W3C Validator do not treat it like error but IMO avoiding empty spans is a good habit.

Additional in new patch - missing FORM close tag added.

[miqrogroove]

No Bug Description

Simek, you can't just throw patches at the developers and expect them to psychically understand why you want them to make changes. If there is a bug here you need to describe what the problem is, where you found it, and how someone else might find the same problem.

[azaozz]

Replying to miqrogroove:

No Bug Description

Not everybody's first language is English. I can understand that it's easier to write code than descriptions. In this case the patch is pretty much self-explanatory.

[miqrogroove]

After all the posts by staff complaining about tickets with a lack of information, I thought it would be helpful to close the bare patches. Once again I'm proven wrong and will let you guys fight amongst yourselves.

Here is the description I was working on to reopen the ticket:

If you look at the Upload/Insert buttons for attaching media to a new post, you can copy those links and hit them directly to grab code for validation. An example path looks like /wp-admin/media-upload.php?post_id=-1261613461&type=image&TB_iframe=true

At such URLs there is a full entity returned with (mostly valid) XHTML doctype. However, each entity contains one FORM element that is not closed, and does cause a validation error.

This was probably introduced at ​http://core.trac.wordpress.org/browser/trunk/wp-admin/includes/media.php?rev=7092

I am not aware of any bug or cosmetic problem caused by the missing close tag.

Enjoy.

[hakre]

Patch did not apply clean any longer. I updated it to relfect the two named changes, ignored the whitespace changes.

[azaozz]

(In [12582]) Remove unneeded empty span and add form closing tag in media.php, props Simek and hakre, fixes #11569