fix_active_plugins() should not be needed

[Denis-de-Bernardy]

Where we call get_option(active_plugins), we should always include a default value of array(). The fix_active_plugins() function should never be needed.

[hakre]

Right, that logic is part of validate_active_plugins() in existing core already (plugin.php). While doing some sniffs over the codebase for a first patch I realize that the newly introduced approach ticks edge-cases here and there.

[hakre]

A first patch that streamlines the reading of the active_plugins value as well as streamlining the loading of both, standard and wpmu plugins based on the standard plugins loading validations. introducing a new function called valid_plugins() which reduces plugin inclusion into a simple foreach clause.

will create a second patch w/o those improvements.

[hakre]

only get_option( 'active_plugins', array() ) where applicable

[hakre]

Second patch taking care of propper default values. Will write the next follow up for fix_active_plugins() removal.

[hakre]

Third patch as the straight fix to the ticket. Could be merged with first patch to improve the codebase if wanted.

[hakre]

Additional info: I tested against loding WPMU and standard plugins. Worked properly (first patch).

[Denis-de-Bernardy]

I like the valid_plugins() idea in the first patch (11750-full-incl-valid-plugins-function.patch)

[ryan]

[12848]