Syntax Error in PHP4

[blepoxp]

Steps to reproduce:
1) Load WordPress trunk (r. 13013) in PHP4
2) Observe following error on screen:

Parse error: syntax error, unexpected T_OBJECT_OPERATOR in /Applications/MAMP/htdocs/wptrunk/wp-includes/theme.php on line 714

It appears that the arrow is causing the problem

$author = get_user_by( 'id', $author_id )->user_nicename;

I fixed by doing the following:

$author = get_user_by( 'id', $author_id );
$author = $author->user_nicename;

[blepoxp]

Adds a new line after 714.

[aaroncampbell]

You'll need to create a patch rather than upload the whole file. A patch is basically a .diff file that shows what CHANGES are made to the file and can be applied to the repository.

[aaroncampbell]

Here, read this: ​http://blog.ftwr.co.uk/archives/2005/11/03/windows-wordpress-toolbox/

[blepoxp]

Sorry. Here's the .diff version

[nacin]

FYI: There's no other instance of function_that_returns_object()->method() or function_that_returns_object()->property in core. This one is it (according to grep).

I wrote it in [12915] forgetting about the PHP4 compat issue.

[aaroncampbell]

Looks good, quick test seems to be working.

[westi]

(In [13014]) Ensure we are PHP4 compat. Fixes #12167 props blepoxp.