WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#12211 closed feature request (fixed)

Make it obvious when a blog is set to private

Reported by: markjaquith Owned by:
Milestone: 3.0 Priority: normal
Severity: minor Version:
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

I've heard reports of people developing a WordPress theme with privacy mode turned on. When launching it, they can forget to turn the privacy mode back off, with disastrous results in search engines.

We should make some sort of indicator when privacy mode is on. Perhaps a lock icon next to the blog name in the wp-admin h1? Clicking it could lead to the Privacy Options page.

Attachments (7)

admin-header.patch (1.1 KB) - added by scottbasgaard 4 years ago.
If blog visibility is disabled "Privacy On" will display in the wp-admin h1.
visibility_patch.png (190.4 KB) - added by scottbasgaard 4 years ago.
screenshot
visibility_patch2.png (191.3 KB) - added by scottbasgaard 4 years ago.
Maybe something like this?
admin-header.php.patch (1.4 KB) - added by scottbasgaard 4 years ago.
wp-admin.css.patch (97.8 KB) - added by scottbasgaard 4 years ago.
wp-admin.dev.css.patch (659 bytes) - added by scottbasgaard 4 years ago.
privacy-on.patch (1.9 KB) - added by scottbasgaard 4 years ago.

Download all attachments as: .zip

Change History (26)

comment:1 nacin4 years ago

  • Milestone changed from Unassigned to 3.0

Absolutely +1. Had a client once that managed to turn privacy mode on and then went nuts when the site dropped out of search. I like the lock icon idea.

comment:2 dd324 years ago

I'm +1 on this idea too, But the mouse-over text is going to need to explain that the lock means its Search-engine lockout, not anything else..

comment:3 janeforshort4 years ago

How about instead of a lock icon that makes people think of SSL, we just do what we do with private posts? In the admin header, next to the site title, add "- Private" in bold letters. Make it clickable to take you to the privacy settings screen, and on hover give tooltip "click to change privacy settings" or some such.

comment:4 nacin4 years ago

I agree the lock could be confused with SSL. On the other hand, private posts require authentication, while privacy mode only deals with search engine access -- the site is very much public. I'm not sure that's any better.

scottbasgaard4 years ago

If blog visibility is disabled "Privacy On" will display in the wp-admin h1.

comment:5 scottbasgaard4 years ago

  • Cc mail@… added
  • Keywords has-patch added; privacy removed

scottbasgaard4 years ago

screenshot

comment:6 nacin4 years ago

I like it. Thanks for adding the title text. The only thing I see is that we'll need to convert site-visit-button from an ID to a class now.

comment:7 automattor4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [13168]) Place a "Privacy On" mini-alert in the wp-admin header when it is on, to prevent people from accidentally delisting themselves from search engines. props scottbasgaard. fixes #12211

comment:8 nacin4 years ago

(In [13169]) Use esc_attr. Fixes #12211

comment:9 janeforshort4 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Making it a button instead of text is a problem. Buttons are used to indicate potential actions, not current statuses. Yes, there's an action associated with it, but the button breaks the UI convention we're trying to make consistent within WP of only using buttons for actual submit actions, not just for links or displays. Secondly, the contrast of that button is so low that it won't pass accessibility guidelines (same for visit site, we need to fix that too, but that's a separate issue).

Better implementation would be something like:

SiteName - Private [view site button]
or
SiteName (Privacy On) [view site button]

comment:10 nacin4 years ago

Not going to bother with a second commit now then, but we'll want to add another esc_attr there for the other title attribute. Maybe some esc_html too.

Making it a button instead of text is a problem. Buttons are used to indicate potential actions, not current statuses. Yes, there's an action associated with it, but the button breaks the UI convention we're trying to make consistent within WP of only using buttons for actual submit actions, not just for links or displays.

Are you also advocating for View Site to no longer be a button?

comment:11 scottbasgaard4 years ago

Wouldn't it be confusing to have SiteName(links to site) - PrivacyNotice(links to privacy options) ViewSiteButton(links to site)?

scottbasgaard4 years ago

Maybe something like this?

scottbasgaard4 years ago

comment:12 scottbasgaard4 years ago

added the other esc_attr_e() and esc_html_e()'s as well

scottbasgaard4 years ago

comment:13 nacin4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [13182]) Modify style of new "Privacy On" admin header indicator. props scottbasgaard, fixes #12211

comment:14 follow-up: nacin4 years ago

Thanks for the follow-up patch. I touched up the CSS a bit on the way in, and reverted most of [13168] by going back to an id for the Visit Site button.

comment:15 in reply to: ↑ 14 nacin4 years ago

Replying to nacin:

Thanks for the follow-up patch. I touched up the CSS a bit on the way in, and reverted most of [13168] by going back to an id for the Visit Site button.

Oops. Just discovered this open tab with a database locked error, which have been rather prevalent this morning. Figured it was from some recent comment, instead I posted a comment I meant to post two days ago.

comment:17 ipstenu3 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Version set to 3.2

It looks like, with the changes to 3.2 and the header, this got dropped. Can it be put back in?

comment:18 dd323 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed
  • Version 3.2 deleted

It looks like, with the changes to 3.2 and the header, this got dropped.

Due to screen space I believe it was dropped from the header as it was using valuable space which could otherwise be used better for the majority of users.

It was moved into the Right Now dashboard widget, but doesn't appear to be very obvious there.

As this ticket was closed for 3.0, It'd be better if you could create a new ticket for 3.2 consideration instead, and reference this ticket.

See [17829] & #17324

comment:19 ipstenu3 years ago

Hmm. now that I know where to look, I'm not sure if it needs to be there or not. I think I'll keep it open for forum discussion.

Note: See TracTickets for help on using tickets.