Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#12666 closed defect (bug) (fixed)

ms-options.php cleanups, and enabling global terms

Reported by: nacin Owned by: nacin
Milestone: 3.0 Priority: high
Severity: critical Version:
Component: Multisite Keywords:
Focuses: Cc:


Changesets related to ms-options.php cleanups so far:

[13794] Move the MS option for upload limit inline w/ the enabling/disabling of the upload limit.

[13795] More cleanup of ms-options.php. Allow textarea.large-text class to be applied to inputs as well.

[13796] More ms-options cleanup. Add label elements, and transition to checkboxes from radios where we can. Also fix notice in global_terms_enabled post handling.

I think we should consider adding a confirmation to enabling global terms, or hide the UI for it if disabled, or something.

I left it as a radio button for now because that seems a little higher of a barrier than a checkbox. But even then, changing the option and hitting submit will result in some major schema changes, and the network admin may not realize that.

I'd also like to transition away from yes/no to bool, but there may be a back compat argument to be had.

Change History (9)

#1 @nacin
6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [14494]) Simple warning text for global terms. Probably not enough considering the sky will fall on your head if you enable them, but it's a start. fixes #12666.

#2 @nacin
6 years ago

  • Priority changed from normal to high
  • Resolution fixed deleted
  • Severity changed from normal to critical
  • Status changed from closed to reopened

We need triple-confirmation and a blinking red bold marquee that global terms causes the sky to fall on your head.

see also #13482.

#3 @nacin
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [14854]) Even better, remove all UI for global terms. Add a filter to global_terms_enabled() and also allow the site option to simply be deleted. fixes #12666.

#4 @wpmuguru
6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

No can do on [14854]. The global terms functionality depends on the sitecategories table. So, we have to keep the functionality that creates the table in core.

#5 @ryan
6 years ago

A plugin can call install_global_terms(), which we can continue to maintain.

#6 @nacin
6 years ago

(In [14880]) Remove the on switch for global terms. install_global_terms() can be triggered in a plugin. see #12666.

#7 @nacin
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

#8 @ryan
6 years ago

We're pushing global terms into plugin territory where it should have remained. We're stuck maintaining the schema and global_terms(), but we should require a plugin to turn it on. MU 2.9 users will still have it turned on after they upgrade to 3.0, but we should publicize instructions for turning it off. That will relieve many people.

#9 @BjornW
5 years ago

  • Cc mailings@… added

I'm on the verge of finishing a plugin (bbAggregate) which allows you to aggregate posts from different blogs in the same wp install to be aggregated based on sitewide categories. What do I need to do to keep this working with WP3 and which issues are you relating to when using the "Sky will be falling on your head"? Would like to help out with any remaining issues for sitewide categories as multiple clients of mine depend on this.

Note: See TracTickets for help on using tickets.