Better server checks in network.php

[nacin]

network.php makes careful double-checks (literally) for mod_rewrite in step 1, but nothing in step 2 when it actually presents the rules.

We should be able to detect mod_rewrite in step 2. If they're not running Apache at all, they probably don't need the Apache rules.

Additionally, we need IIS detection and support in both steps.

[Frumph]

Rewrite Rules changes and check for IIS / apache for the network page.

[Frumph]

There's just one problem with the .diff is the content portion which i've commented on, otherwise it's working on my end where the network page displays the appropriate rules for.

Another thing it would be nice if I could call the function iis7_url_rewrite_rules from inside of the network.php file, unfortunately I do not know how to call functions inside of a class.

[Frumph]

Found some bugs in the url rewrite diff, fixing them now.

[westi]

Please don't do this:

$indent.$indent.$indent

It makes it really hard to read.

Much better to just use a multi-line string.

If this doesn't get a patch in the next couple of days it will likely miss 3.0

[filosofo]

Does IIS require indentation for code logic, like Python or something?

[ruslany]

No, identation does not affect the IIS runtime. The reason identation is added is so that the rules preview in the Options -> Permalinks page and in the generated configuration file look nice with proper XML indentation.

[Frumph]

Well the problem with what I wrote above in that .diff is that the "mainsite" url doesnt transfer 404's, the subsites, mulsitesites off of the main site work just fine.

[wpmuguru]

Do we have a patch that works & can be applied?

[Frumph]

Alright I figured it out, it's in the wordpress code someplace that the problem is, why? cause this is why.

{{{define('VHOST', 'yes');
If VHOST is 'yes' uncomment and set this to a URL to redirect if a blog does not exist or is a 404 on the main blog. (Useful if signup is disabled)
For example, the browser will redirect to ​http://examples.com/ for the following: define( 'NOBLOGREDIRECT', '​http://example.com/' );
Set this value to %siteurl% to redirect to the root of the site
define( 'NOBLOGREDIRECT', '​http://frumph.net' );
On a directory based install you must use the theme 404 handler.
}}}
If I uncomment the define( no blog redirect, which it was it will have the problem where the main site doesnt go to the 404 error page. if I keep it there, the url rewrite rules I wrote above will work fine.

[Frumph]

Okay anyways, uncommenting the noblogredirect in the wp-config.php is the issue.

[Frumph]

Okay this is all working, subdirectory, subdomain and shows the info in the network panel.

[wpmuguru]

That all works. The problem we have is that the NOBLOGREDIRECT served a dual purpose of both no blog and 404 redirect. As much as I hate to do it, we're going to have to add another constant.

[wpmuguru]

(In [14871]) update rewrite rules for IIS, props Frumph, see #12758

[wpmuguru]

To prevent the 404 redirect add

define( 'NO404REDIRECT', true );

I wanted to get the patch in before RC, but the

$indent.$indent.$indent

has to be addressed before closing the ticket.

[nacin]

That doesn't get fired until template_redirect, so surely we can use a filter here instead...

[Frumph]

What would be best would be the display in the network panel how it displays what to put in the web.config should be generated by the same code that actually does it so it doesn't double up on the information. But that can be an update for 3.1 and I can work on that., for now ron's new define works.

[filosofo]

remove-indents.12758.diff is my attempt to make things a little more readable.

[wpmuguru]

(In [14885]) cleanup $indents, props filosofo, see #12758

[Frumph]

You do know the indents were there to make things display properly in the networks panel right?

[nacin]

Replying to Frumph:

You do know the indents were there to make things display properly in the networks panel right?

The indents are directly in the strings now.

[nacin]

(In [14899]) Use a filter instead of a new NO404REDIRECT constant. see #12758.

[wpmuguru]

I;m going to apply another improvement to this one and mark it as fixed. If something shows up re-open the ticket.

[wpmuguru]

(In [14911]) allow main site 404 URL to be filtered, fixes #12758

[nacin]

[15024]

[nacin]

(In [15025]) Add some Apache checks to some notices in network.php. see #12758.

[nacin]

(In [15026]) Better branching to account for mod_rewrite mimicry. see #12758.